[Addressing] Province rendering tweaks #3953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NoResponseMate
commented
Jan 22, 2016
NoResponseMate
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | yes |
| Deprecations? | no |
| Fixed tickets | #3902 |
| License | MIT |
| Doc PR | - |
pjedrzejewski
added
Enhancement
michalmarcinkowski
changed the title
| @@ -30,6 +30,9 @@ public function buildForm(FormBuilderInterface $builder, array $options) | |||
| ->add('name', 'text', array( | |||
| 'label' => 'sylius.form.province.name', | |||
| )) | |||
| ->add('abbreviation', 'text', array( | |||
| 'label' => 'sylius.form.province.abbreviation', | |||
There was a problem hiding this comment.
It's not required so we should set it to false here.
|
Looks good to me, let's fix the build, merge it and add caching in another PR. |
| ->willReturn($provinceForm); | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Redundant blank spaces
|
Add fallback to |
|
Thanks for getting this done so quickly :) 👍 |
NoResponseMate
force-pushed
the
province-filters-galore
branch
from
180fb7d
to
1159f2c
Compare
pjedrzejewski
pushed a commit
that referenced
this pull request
Jan 22, 2016
[Addressing] Province rendering tweaks
|
Thank you Jasiek! 👍 :) |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
…lore [Addressing] Province rendering tweaks
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
…lore [Addressing] Province rendering tweaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.