[Review] SyliusReviewBundle #3980

GSadee · 2016-01-26T13:34:59Z

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Fixed tickets
License	MIT
Doc PR

Initial implementation of SyliusReviewBundle, which allows to easily manage review system. It's based on @Zales0123 #3300.

"Reviewable" and "Reviewer" classes can be configured under sylius_review tag:

sylius_review:
    resources:
        product:
            subject: %sylius.model.product.class%
            review:
                classes:
                    model: Sylius\Component\Core\Model\ProductReview
                    form:
                        default: Sylius\Bundle\CoreBundle\Form\Type\ProductReviewType
                        admin: Sylius\Bundle\CoreBundle\Form\Type\ProductReviewAdminType
            reviewer:
                classes:
                    model: Sylius\Component\Core\Model\Customer

I have added changes from #3372 and extended this PR to use CustomerGuestType in ReviewType.

aramalipoor · 2016-01-28T11:37:13Z

app/migrations/Version20150825160125.php

+        // this up() migration is auto-generated, please modify it to your needs
+        $this->abortIf($this->connection->getDatabasePlatform()->getName() != 'mysql', 'Migration can only be executed safely on \'mysql\'.');
+
+        $this->addSql('ALTER TABLE sylius_review DROP FOREIGN KEY FK_43626F3A4584665A');


No need for these (3) migrations! Only 1 is sufficient, which adds/removes review table :D

pjedrzejewski · 2016-01-29T13:36:11Z

@GSadee Rebase has gone wrong this one probably... :)

nakashu · 2016-02-02T10:44:58Z

@GSadee @pjedrzejewski can you estimate when this will be finished? Got a project in development where reviews are needed, so wanted to know if I should wait or implement it on my own.
thanks.

pjedrzejewski · 2016-02-02T10:49:25Z

We need this too and we want to get it merged by the end of the week. I would review it today already but rebase went really wrong...

michalmarcinkowski · 2016-02-02T10:49:57Z

@nakashu it will be done ASAP. We want to merge it this week.

nakashu · 2016-02-02T10:55:01Z

great to hear. thanks

nakashu · 2016-02-02T10:59:00Z

I'll probably add support for schema aggregate rating in PR after you merge this. (if it is not present.)

Propabably for another RFC, is how to implement it.

json-lc - this can be decoupled from temlplate, but is less supported/trusted
microdata - coupled to templates, or using macros and some crazy template stuff.

https://schema.org/AggregateRating

WIll create an RFC after merge.

Zales0123 · 2016-02-03T10:11:26Z

features/reviews/reviews.feature

+    Scenario: Seeing created reviews in the list
+        Given I am on the dashboard page
+         When I follow "Product reviews"
+         Then I should see 3 reviews in the list


We shall be consistent and align all new scenarios to left.

Split configurations into Review-, Product- and CoreBundle parts

Also some general and CS fixes.

Also some changes/fixes in templates and crucial changes in review creation.

Also some minor PR review fixes

…alidator

…tead of ResourceController

pjedrzejewski · 2016-02-19T10:24:51Z

src/Sylius/Bundle/ReviewBundle/composer.json

+    },
+    "extra": {
+        "branch-alias": {
+            "dev-master": "0.17/-dev"


Remove /.

[Review] SyliusReviewBundle

pjedrzejewski · 2016-02-19T13:35:12Z

Long road but we have made it, thanks Grzegorz, Mateusz, Daniel and everyone involved! 👍 🎆

michalmarcinkowski · 2016-02-19T13:36:16Z

That was a big one! Great to see it merged! Thanks everyone 👍

Zales0123 · 2016-02-19T13:39:16Z

I'm really glad to see it merged 🎉

[Review] SyliusReviewBundle

pjedrzejewski added the New Feature label Jan 26, 2016

pjedrzejewski mentioned this pull request Jan 26, 2016

[WIP] [Review] SyliusReviewBundle #3300

Closed

7 tasks

pjedrzejewski added the Awaiting Review label Jan 26, 2016

pjedrzejewski mentioned this pull request Jan 27, 2016

[Taxonomy] Remove Taxonomy entity in favor of Taxon #3773

Merged

michalmarcinkowski added this to the v0.17.0 milestone Jan 27, 2016

aramalipoor reviewed Jan 28, 2016
View reviewed changes

GSadee force-pushed the sylius-review-bundle branch from 65e15ce to dda2112 Compare January 29, 2016 10:37

GSadee force-pushed the sylius-review-bundle branch from dda2112 to dad43bf Compare February 3, 2016 09:19

Zales0123 reviewed Feb 3, 2016
View reviewed changes

Zales0123 and others added 17 commits February 19, 2016 08:48

[Review] Make reviews more generic

2c019b7

Split configurations into Review-, Product- and CoreBundle parts

[Review] Split ProductReviewAdminType to Product- and CoreBundle part

85e0420

[Review] Implemented ReviewDeleteListener

d216f9e

Also some general and CS fixes.

[Review] Change ReviewAuthorInterface to ReviewerInterface

9036bd3

[Review] Added default Reviewer class

bbe88ce

[Review] Added listeners on Product and Customer deletion

5b08884

[Review] PR review changes vol.1

97f5fe0

[Review] Added dynamic tags on ReviewDeleteListener

e007721

Also some changes/fixes in templates and crucial changes in review creation.

[Review] Fixed javascripts scenarios

c349d27

Also some minor PR review fixes

[Review] Changed configuration after changes in ResourceBundle

c31bfe4

[Review] Added customer guest type to review and fixed unique email v…

ad1703b

…alidator

[Review] Fixed updating review state

650f7ef

[Review] Fixed problem with lowercase text on buttons

21e2f8f

[Review] Fixed relation between Product and Reviews

17fffcb

[Review] Changed ProductReviewController to use FOSRestController ins…

c9ef294

…tead of ResourceController

[Review] Changed migrations files for review

5a11a2e

[Review] CS fixes

a2167e3

GSadee force-pushed the sylius-review-bundle branch from 94e26b0 to 6a793f9 Compare February 19, 2016 07:49

pjedrzejewski reviewed Feb 19, 2016
View reviewed changes

src/Sylius/Bundle/ReviewBundle/composer.json

},

"extra": {

"branch-alias": {

"dev-master": "0.17/-dev"

Copy link

Member

pjedrzejewski Feb 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove /.

[Review] Fixes after PR review

c9a86d0

GSadee force-pushed the sylius-review-bundle branch from 6a793f9 to c9a86d0 Compare February 19, 2016 11:10

pjedrzejewski pushed a commit that referenced this pull request Feb 19, 2016

Merge pull request #3980 from GSadee/sylius-review-bundle

8ef740e

[Review] SyliusReviewBundle

pjedrzejewski merged commit 8ef740e into Sylius:master Feb 19, 2016

loicmobizel mentioned this pull request May 12, 2016

[WIP] SyliusLikeBundle - User can like or dislike a resource #5012

Closed

GSadee deleted the sylius-review-bundle branch September 22, 2017 08:31

pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019

Merge pull request Sylius#3980 from GSadee/sylius-review-bundle

cca7cef

[Review] SyliusReviewBundle

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Review] SyliusReviewBundle #3980

[Review] SyliusReviewBundle #3980

GSadee commented Jan 26, 2016

aramalipoor Jan 28, 2016

pjedrzejewski commented Jan 29, 2016

nakashu commented Feb 2, 2016

pjedrzejewski commented Feb 2, 2016

michalmarcinkowski commented Feb 2, 2016

nakashu commented Feb 2, 2016

nakashu commented Feb 2, 2016

Zales0123 Feb 3, 2016

pjedrzejewski Feb 19, 2016

pjedrzejewski commented Feb 19, 2016

michalmarcinkowski commented Feb 19, 2016

Zales0123 commented Feb 19, 2016

[Review] SyliusReviewBundle #3980

[Review] SyliusReviewBundle #3980

Conversation

GSadee commented Jan 26, 2016

aramalipoor Jan 28, 2016

Choose a reason for hiding this comment

pjedrzejewski commented Jan 29, 2016

nakashu commented Feb 2, 2016

pjedrzejewski commented Feb 2, 2016

michalmarcinkowski commented Feb 2, 2016

nakashu commented Feb 2, 2016

nakashu commented Feb 2, 2016

Zales0123 Feb 3, 2016

Choose a reason for hiding this comment

pjedrzejewski Feb 19, 2016

Choose a reason for hiding this comment

pjedrzejewski commented Feb 19, 2016

michalmarcinkowski commented Feb 19, 2016

Zales0123 commented Feb 19, 2016