[Attribute] Fix hardcoded strings in attribute templates #4014
Conversation
Zales0123
commented
Jan 29, 2016
Zales0123
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets | #3984 |
| License | MIT |
| Doc PR |
| @@ -8,7 +8,8 @@ | |||
| <div class="modal-body"> | |||
| <div class="list-group"> | |||
| {% for name, attributeType in attributeTypes %} | |||
| <a href="{{ path('sylius_backend_product_attribute_create', { 'type': name }) }}" id="{{ name }}" class="list-group-item"> | |||
| {% set route = 'sylius_backend_'~subject~'_create' %} | |||
There was a problem hiding this comment.
I supposer the subject is product, so shouldn't it be "sylius_backend_'subject'_attribute_create"?
There was a problem hiding this comment.
In fact, subject is "product_attribute"... perhaps variable name is not the best choice 😄
| @@ -14,9 +14,9 @@ | |||
| <div class="form-group"> | |||
| {% set id = form.vars.label|replace(' ', '_')|lower %} | |||
| <label class="col-lg-2 control-label required" for="{{ id }}">{{ form.vars.label }}</label> | |||
| <input type="hidden" name="sylius_product[attributes][{{ count }}][attribute]" id="sylius_product_attributes_{{ count }}_attribute" value="{{ attributeId }}"/> | |||
| <input type="hidden" name="sylius_{{ subject }}[attributes][{{ count }}][attribute]" id="sylius_{{ subject }}_attributes_{{ count }}_attribute" value="{{ attributeId }}"/> | |||
There was a problem hiding this comment.
The [attributes] aren't actually [values]?
There was a problem hiding this comment.
I think it was a talk about attributes collection name some time ago, but it has not been fixed yet. Sure it should be, but I think it's not a case of this PR ;)
Zales0123
force-pushed
the
attribute-bugs
branch
from
8a51f09
to
7e2433e
Compare
| @@ -8,7 +8,8 @@ | |||
| <div class="modal-body"> | |||
| <div class="list-group"> | |||
| {% for name, attributeType in attributeTypes %} | |||
| <a href="{{ path('sylius_backend_product_attribute_create', { 'type': name }) }}" id="{{ name }}" class="list-group-item"> | |||
| {% set route = 'sylius_backend_'~subject~'_attribute_create' %} | |||
There was a problem hiding this comment.
what if you're application isn't sylius? I think you need to pass application name here
There was a problem hiding this comment.
Hah 😄 good point Peter 👍
There was a problem hiding this comment.
👍 I think, I'll follow @pjedrzejewski advice and pass metadata object into these templates.
|
@Zales0123 You can pass |
Zales0123
force-pushed
the
attribute-bugs
branch
from
7e2433e
to
7f998a6
Compare
|
Looks good now 👍 |
[Attribute] Fix hardcoded strings in attribute templates
|
Thank you Mateusz! 👍 |
