[Cart] Cart with shipping fee and product taxes #4032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjedrzejewski
added
the
Enhancement
Zales0123
force-pushed
the
cart-with-shipping-fee-and-product-taxes
branch
6 times, most recently
from
fd11a95
to
9d5e3fa
Compare
|
Ok, I think now it's ready to be reviewed ;) |
| And product "PHP T-Shirt" belongs to "Clothes" tax category | ||
| And store has "DHL" shipping method with "€10.00" fee within "EU" zone | ||
| And store has "DHL-World" shipping method with "€10.00" fee for the rest of the world | ||
| And shipping method "DHL" belongs to "Clothes" tax category |
There was a problem hiding this comment.
Shipping method should belong to shipping tax category
Zales0123
force-pushed
the
cart-with-shipping-fee-and-product-taxes
branch
from
9d5e3fa
to
63e3b91
Compare
pjedrzejewski
pushed a commit
that referenced
this pull request
Feb 9, 2016
…oduct-taxes [Cart] Cart with shipping fee and product taxes
|
Thanks Mateusz! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #4010. Added scenario for cart with taxed shipments and taxed products.
Hopefully, after merges of one or two previous PR's, review of this one will be... possible :)