-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OptionValue] Translation System #4051
Conversation
return $this->option->getPresentation(); | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing eof new line
@pjedrzejewski I've finished on this PR. When you think you will merge this PR? |
@@ -184,7 +187,7 @@ private function addClassesSection(ArrayNodeDefinition $node) | |||
->scalarNode('interface')->isRequired()->cannotBeEmpty()->end() | |||
->scalarNode('controller')->defaultValue(ResourceController::class)->cannotBeEmpty()->end() | |||
->scalarNode('repository')->cannotBeEmpty()->cannotBeEmpty()->end() | |||
->scalarNode('factory')->defaultValue(Factory::class)->end() | |||
->scalarNode('factory')->defaultValue(TranslatableFactory::class)->end() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This node should cannot be empty as well
/** | ||
* @param string $dataClass | ||
* @param array $validationGroups | ||
* @param $variableName |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing typehint
[OptionValue] Translation System
Nice work Vincenzo! Thank you very much. 👍 |
Thanks @pjedrzejewski I would like to help with something else :) |
ok @michalmarcinkowski thanks :) |
[OptionValue] Translation System
[OptionValue] Translation System
[OptionValue] Translation System
This PR is based from #3975