Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Customer groups #406

Merged
merged 2 commits into from
Oct 30, 2013
Merged

[WIP] Customer groups #406

merged 2 commits into from
Oct 30, 2013

Conversation

pjedrzejewski
Copy link
Member

No description provided.

| beth@foo.com | no | Klaus Schmitt, Heine-Straße 12, 99734, Berlin, Germany |
| martha@foo.com | yes | Lars Meine, Fun-Straße 1, 90032, Vienna, Austria |
| rick@foo.com | no | Klaus Schmitt, Heine-Straße 12, 99734, Berlin, Germany |
| dale @foo.com | yes | Lars Meine, Fun-Straße 1, 90032, Vienna, Austria |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in dale @foo.com, the space should be removed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯

pjedrzejewski pushed a commit that referenced this pull request Oct 30, 2013
@pjedrzejewski pjedrzejewski merged commit 80214c3 into master Oct 30, 2013
@pjedrzejewski pjedrzejewski deleted the customer-groups branch October 30, 2013 11:03
@pjedrzejewski
Copy link
Member Author

Thanks Pawel. 💃 (foreveralone)

@stloyd
Copy link
Contributor

stloyd commented Oct 30, 2013

I wanted to review that! :trollface:

@@ -99,3 +99,7 @@ sylius_resource:
model: Sylius\Bundle\CoreBundle\Model\User
controller: Sylius\Bundle\CoreBundle\Controller\UserController
repository: Sylius\Bundle\CoreBundle\Repository\UserRepository
sylius.group:
driver: doctrine/orm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be ommited.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not here I think.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah it's resource... I was thinking about ommiting here too, but I decided that it would be quite hacky implementation =)

@jjanvier
Copy link
Contributor

Thanks pawel ! Awesome work 👍

xD

pamil pushed a commit to pamil/Sylius that referenced this pull request Mar 21, 2016
Add Collection type hint + add hasAttributeByCode/getAttributeByCode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants