-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Customer groups #406
Conversation
| beth@foo.com | no | Klaus Schmitt, Heine-Straße 12, 99734, Berlin, Germany | | ||
| martha@foo.com | yes | Lars Meine, Fun-Straße 1, 90032, Vienna, Austria | | ||
| rick@foo.com | no | Klaus Schmitt, Heine-Straße 12, 99734, Berlin, Germany | | ||
| dale @foo.com | yes | Lars Meine, Fun-Straße 1, 90032, Vienna, Austria | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in dale @foo.com
, the space should be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯
Thanks Pawel. 💃 (foreveralone) |
I wanted to review that! |
@@ -99,3 +99,7 @@ sylius_resource: | |||
model: Sylius\Bundle\CoreBundle\Model\User | |||
controller: Sylius\Bundle\CoreBundle\Controller\UserController | |||
repository: Sylius\Bundle\CoreBundle\Repository\UserRepository | |||
sylius.group: | |||
driver: doctrine/orm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be ommited.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not here I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah it's resource
... I was thinking about ommiting here too, but I decided that it would be quite hacky implementation =)
Thanks pawel ! Awesome work 👍 xD |
Add Collection type hint + add hasAttributeByCode/getAttributeByCode
No description provided.