Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Channel] Cached per request channel context #4067

Merged
merged 3 commits into from
Feb 10, 2016

Conversation

pamil
Copy link
Contributor

@pamil pamil commented Feb 5, 2016

Based on #4056.

@pjedrzejewski pjedrzejewski added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Feb 6, 2016
@pamil pamil changed the title [WIP] [Channel] Cached per request channel context [Channel] Cached per request channel context Feb 8, 2016

<parameter key="sylius.context.channel.request_based.resolver.composite.class">Sylius\Component\Channel\Context\RequestBased\CompositeRequestResolver</parameter>
<parameter key="sylius.context.channel.request_based.resolver.hostname_based.class">Sylius\Component\Channel\Context\RequestBased\HostnameBasedRequestResolver</parameter>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant blank line

@michalmarcinkowski
Copy link
Contributor

👍

pjedrzejewski pushed a commit that referenced this pull request Feb 10, 2016
[Channel] Cached per request channel context
@pjedrzejewski pjedrzejewski merged commit 33f9ae0 into Sylius:master Feb 10, 2016
@pjedrzejewski
Copy link
Member

Thank you Kamil! 👍

@pamil pamil deleted the channel-cached-contexts branch February 10, 2016 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants