Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Travis] Do not rerun tests on fatal errors #4077

Merged
merged 1 commit into from
Feb 9, 2016

Conversation

pamil
Copy link
Contributor

@pamil pamil commented Feb 8, 2016

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets -
License MIT
Doc PR -

Fatal errors does not allow Behat to recognize which scenarios were already executed & passed and all tests are rerun, which results in twice as long build times, failing anyway.

@pamil pamil changed the title [Travis] Do not rerun tests on fatal errors [WIP] [Travis] Do not rerun tests on fatal errors Feb 8, 2016
@pamil
Copy link
Contributor Author

pamil commented Feb 8, 2016

Adding [WIP] as it seems like Travis handles error code in some weird way.

@pamil pamil changed the title [WIP] [Travis] Do not rerun tests on fatal errors [Travis] Do not rerun tests on fatal errors Feb 9, 2016
@pamil
Copy link
Contributor Author

pamil commented Feb 9, 2016

Nailed it, going green in just a few minutes!

pjedrzejewski pushed a commit that referenced this pull request Feb 9, 2016
[Travis] Do not rerun tests on fatal errors
@pjedrzejewski pjedrzejewski merged commit 2f2d5b1 into Sylius:master Feb 9, 2016
@pjedrzejewski
Copy link
Member

👍

@pamil pamil deleted the behat-rerunning branch March 18, 2016 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants