[Core] Removed OrderItem based promotions #4103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
michalmarcinkowski
added
the
BC Break
| @@ -223,6 +223,7 @@ class BookController extends ResourceController | |||
| ### Core and CoreBundle | |||
|
|
|||
| * Moved ``taxCategory`` from ``Product`` to ``ProductVariant`` | |||
| * Set ``OrderItem`` not to be ``PromotionSubject`` | |||
There was a problem hiding this comment.
Set not to be... 💃
OrderItemmodel from Core component no longer implementsPromotionSubjectInterface, remove all usages ofaddPromotion, etc. from your custom code. Custom actions targeting items need to be adjusted, seeContainsProductRuleCheckerfor reference.
There was a problem hiding this comment.
I knew that it's not good enough 😄 👍
Zales0123
force-pushed
the
remove-order-item-based-promotions
branch
from
1077d25
to
8efdcd3
Compare
michalmarcinkowski
added a commit
that referenced
this pull request
Feb 11, 2016
…tions [Core] Removed OrderItem based promotions
|
For reference purpose: #4954 |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
…-promotions [Core] Removed OrderItem based promotions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In favor of upcoming changes with promotions system, it's time to clean up a little bit :) Here I remove some residues of
OrderItem-based promotions.