[Core] Fixed payment history issue #4136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NoResponseMate
commented
Feb 12, 2016
NoResponseMate
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets | #4110 |
| License | MIT |
| Doc PR | - |
| 'logs' => $logRepository->getLogEntries($payment), | ||
| ]) | ||
| ; | ||
| $view = View::create($configuration); |
There was a problem hiding this comment.
Why passing $configuration as argument?
There was a problem hiding this comment.
First arg is data, which you override later.
NoResponseMate
force-pushed
the
payment-historian-fix
branch
from
4c39b29
to
bfbdc2c
Compare
pjedrzejewski
pushed a commit
that referenced
this pull request
Feb 15, 2016
[Core] Fixed payment history issue
|
Thank you Jasiek! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.