Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fixtures][promotion] - add channels and priority to fixtures #4163

Merged
merged 1 commit into from
Feb 18, 2016

Conversation

nakashu
Copy link
Contributor

@nakashu nakashu commented Feb 15, 2016

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed Issues #3813
License MIT

Promotions where missing channel assiations and priority ordering.
It is important for priority to have set non equal values (eg. all 0), as gedmo sortable isn't able properly set the values then, and the sorting won't change.

@Zales0123
Copy link
Member

I believe there are some changes needed in this PR after #4203 merge

@nakashu
Copy link
Contributor Author

nakashu commented Feb 18, 2016

updated. thanks Zales0123.

@michalmarcinkowski
Copy link
Contributor

Will fix #3813

pjedrzejewski pushed a commit that referenced this pull request Feb 18, 2016
[fixtures][promotion] - add channels and priority to fixtures
@pjedrzejewski pjedrzejewski merged commit be65a1b into Sylius:master Feb 18, 2016
@pjedrzejewski
Copy link
Member

Thanks @nakashu! 👍

vmilersky pushed a commit to ThreeSixtyEu/Sylius that referenced this pull request Mar 7, 2016
vmilersky pushed a commit to ThreeSixtyEu/Sylius that referenced this pull request Mar 7, 2016
vmilersky pushed a commit to ThreeSixtyEu/Sylius that referenced this pull request Mar 7, 2016
vmilersky pushed a commit to ThreeSixtyEu/Sylius that referenced this pull request Mar 7, 2016
vmilersky pushed a commit to ThreeSixtyEu/Sylius that referenced this pull request Mar 7, 2016
vmilersky pushed a commit to ThreeSixtyEu/Sylius that referenced this pull request Mar 7, 2016
vmilersky pushed a commit to ThreeSixtyEu/Sylius that referenced this pull request Mar 7, 2016
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
[fixtures][promotion] - add channels and priority to fixtures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants