[User] Account renewal feature scenarios #4175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoderMaggie
force-pushed
the
account-renewal
branch
6 times, most recently
from
a39224f
to
3118008
Compare
CoderMaggie
changed the title
|
@TheMadeleine Please rebase, thank you! |
CoderMaggie
force-pushed
the
account-renewal
branch
from
3118008
to
26036ed
Compare
| And he had an order | ||
| But his account was deleted | ||
|
|
||
| @ui @javascript |
There was a problem hiding this comment.
Do we need @javascript for this scenario?
CoderMaggie
force-pushed
the
account-renewal
branch
2 times, most recently
from
e423689
to
e04c9d4
Compare
|
@pjedrzejewski @michalmarcinkowski corrections applied. |
| @@ -104,4 +106,21 @@ function it_checks_if_account_was_deleted( | |||
|
|
|||
| $this->accountShouldBeDeleted(); | |||
| } | |||
|
|
|||
| function it_tries_to_register_new_account( | |||
| $registerPage | |||
There was a problem hiding this comment.
Should be in one line. Same as above.
CoderMaggie
force-pushed
the
account-renewal
branch
from
e04c9d4
to
a11cf04
Compare
| @@ -19,6 +19,7 @@ | |||
| <parameter key="sylius.behat.context.setup.payment.class">Sylius\Behat\Context\Setup\PaymentContext</parameter> | |||
| <parameter key="sylius.behat.context.setup.security.class">Sylius\Behat\Context\Setup\SecurityContext</parameter> | |||
| <parameter key="sylius.behat.context.setup.user.class">Sylius\Behat\Context\Setup\UserContext</parameter> | |||
| <parameter key="sylius.behat.context.setup.order.class">Sylius\Behat\Context\Setup\OrderContext</parameter> | |||
There was a problem hiding this comment.
Why did you add this parameter? It is not used in this file.
CoderMaggie
force-pushed
the
account-renewal
branch
from
a11cf04
to
ad70444
Compare
michalmarcinkowski
added
the
Enhancement
|
|
||
| if (null === $flashMessage) { | ||
| throw new \Exception('Account is not registered.'); | ||
| } |
There was a problem hiding this comment.
IMO this method should return boolean. return null !== $flashMessage and then in the context expect($this->registerPage->wasRegistrationSuccessful)->toBe(true) like here
CoderMaggie
force-pushed
the
account-renewal
branch
2 times, most recently
from
5f5f1a4
to
295d293
Compare
| { | ||
| $registerPage->wasRegistrationSuccessful()->willReturn(false); | ||
|
|
||
| $this->shouldThrow('PhpSpec\Exception\Example\FailureException')->during('iShouldBeRegistered'); |
There was a problem hiding this comment.
FailureException::class
CoderMaggie
force-pushed
the
account-renewal
branch
from
295d293
to
93bde48
Compare
| * @param SharedStorageInterface $sharedStorage | ||
| * @param UserRepositoryInterface $userRepository | ||
| * @param CustomerShowPage $customerShowPage | ||
| * @param LoginPage $loginPage | ||
| * @param RegisterPage $registerPage |
There was a problem hiding this comment.
Since we try to introduce new approach it should be type hinted with an interface. Also check this in spec of this class
CoderMaggie
force-pushed
the
account-renewal
branch
from
93bde48
to
a7f0850
Compare
pjedrzejewski
pushed a commit
that referenced
this pull request
Mar 9, 2016
[User] Account renewal feature scenarios
|
Thanks Magda! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on: #4009