[Checkout] Quick fix behat command on travis #4232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Arminek
commented
Feb 19, 2016
Arminek
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
| fi; | ||
|
|
||
| if [[ $EXIT_CODE -eq 1 && $TRAVIS_PULL_REQUEST = false && ! -z "$SYMFONY__PAYPAL__EXPRESS_CHECKOUT__USERNAME" ]]; then | ||
| bin/behat --strict -p cached --rerun --tags=paypal; EXIT_CODE=$? | ||
| bin/behat --strict -p cached --rerun --tags "paypal&&~todo"; EXIT_CODE=$? |
There was a problem hiding this comment.
Just my obsession, can we make a space before and after &&?
There was a problem hiding this comment.
And add @ before tag names to be consistent with suites filters etc.
|
There's a possibility that Behat fails whereas Travis passes. Without PayPal:
With PayPal:
We have to change: bin/behat ; EXIT_CODE = $?to: bin/behat || EXIT_CODE = $? |
|
It won't work anyway, but thanks for tips 👍 |
| fi; | ||
|
|
||
| exit $EXIT_CODE | ||
| checkBuild $EXIT_BEHAT_TEST_CODE $EXIT_BEHAT_PAYPAL_TEST_CODE |
There was a problem hiding this comment.
The following will not work?
$EXIT_CODE = [ $EXIT_BEHAT_TEST_CODE -eq 0 ]] && [[ $EXIT_BEHAT_PAYPAL_TEST_CODE -eq 0 ]
exit $EXIT_CODE
pjedrzejewski
pushed a commit
that referenced
this pull request
Feb 23, 2016
[Checkout] Quick fix behat command on travis
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.