[Behat][Promotion] Discount based on cart quantity #4257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Scenario: Receiving discount when buying more than required quantity | ||
| Given the promotion gives "€10.00" fixed discount to every cart with quantity at least 3 | ||
| Given the promotion gives "€10.00" fixed discount to every order with quantity at least 3 |
There was a problem hiding this comment.
cart is correct, why changing this?
There was a problem hiding this comment.
I've tried to be consistent with previously implemented steps. There is already step "And it gives "€10.00" fixed discount to every order". Do you think cart is more correct and it should be changed in previous steps?
|
Requires rebasing. Thanks! |
Zales0123
force-pushed
the
discount-based-on-cart-quantity
branch
from
eadc7c3
to
5fef96c
Compare
pjedrzejewski
added
the
Enhancement
pjedrzejewski
pushed a commit
that referenced
this pull request
Feb 23, 2016
[Behat][Promotion] Discount based on cart quantity
|
Thanks Mateusz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #4249.
There is few things done in this PR connected with implementation of
receiving_discount_based_on_cart_quantityfeature:RuleFactory- as it have been done withActionFactorybut already in proper namespacemy cart promotionstomy discount, changes in other scenarios will be done in separate PRCartQuantityRuleCheckerto always check>=condition - this change should be done for all checkers and it will be proposed and explained in separate PR