[Behat][Promotion] Percentage discount on products from specific taxon #4286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zales0123
force-pushed
the
percentage-discount-on-products-from-specific-category
branch
from
41e0783
to
47d8dc2
Compare
| And the store has a product "PHP Mug" priced at "€20.00" | ||
| And it belongs to "Mugs" | ||
| And there is a promotion "T-Shirts promotion" | ||
| And it gives "20%" percentage discount to every order item containing products from "T-Shirts" taxon |
There was a problem hiding this comment.
IMO: to every order item containing products from "T-Shirts" taxon
Zales0123
force-pushed
the
percentage-discount-on-products-from-specific-category
branch
2 times, most recently
from
10ac1f6
to
fb2e0f3
Compare
|
|
||
| @todo | ||
| Scenario: Receiving different discounts on different categories | ||
| And there is a promotion "Mugs promotion" |
pjedrzejewski
added
Enhancement
Zales0123
force-pushed
the
percentage-discount-on-products-from-specific-category
branch
from
fb2e0f3
to
59abddd
Compare
| And the store has a product "PHP Mug" priced at "€20.00" | ||
| And it belongs to "Mugs" | ||
| And there is a promotion "T-Shirts promotion" | ||
| And it gives "20%" percentage discount to every order item from "T-Shirts" taxon |
There was a problem hiding this comment.
20% percentage??? This step sounds almost technical.
And it gives 20% off every product classified as "T-Shirts"
WDYT?
There was a problem hiding this comment.
Or we can replace off with discount, does not matter imho.
There was a problem hiding this comment.
It has been done this way in previous scenarios ;) but sure, I think we can skip this percentage word.
Zales0123
force-pushed
the
percentage-discount-on-products-from-specific-category
branch
2 times, most recently
from
e4e97d4
to
29d580b
Compare
Zales0123
force-pushed
the
percentage-discount-on-products-from-specific-category
branch
from
29d580b
to
d448349
Compare
michalmarcinkowski
added a commit
that referenced
this pull request
Mar 1, 2016
…ts-from-specific-category [Behat][Promotion] Percentage discount on products from specific taxon
|
👍 |
Zales0123
deleted the
percentage-discount-on-products-from-specific-category
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is next portion of scenarios about promotions - however this time it would finally require some more coding 😄 However, for now there is only feature, which describes new promotions case - applying promotions only to product from specific taxon.