Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Behat] Add selenium server standalone in require-dev #4299

Merged
merged 1 commit into from
Feb 25, 2016

Conversation

Niiko
Copy link

@Niiko Niiko commented Feb 24, 2016

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets #4293
License MIT
Doc PR -

@pjedrzejewski pjedrzejewski added RFC Discussions about potential changes or new features. DX Issues and PRs aimed at improving Developer eXperience. labels Feb 24, 2016
@pjedrzejewski
Copy link
Member

What do you folks think? Sounds good to me.

@pamil
Copy link
Contributor

pamil commented Feb 25, 2016

Looks good, we can also adjust Travis to use it instead of downloading it itself (etc/travis/prepare-javascript). It would be nice to have Chromedriver downloaded by Composer as well.

pjedrzejewski pushed a commit that referenced this pull request Feb 25, 2016
[Behat] Add selenium server standalone in require-dev
@pjedrzejewski pjedrzejewski merged commit 4f4b30a into Sylius:master Feb 25, 2016
@pjedrzejewski
Copy link
Member

Thanks @Niiko! 👍

@Niiko Niiko deleted the selenium branch May 9, 2016 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Issues and PRs aimed at improving Developer eXperience. RFC Discussions about potential changes or new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants