[MoneyBundle] [CurrencyBundle] Add interface for MoneyHelper and repl… #4307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalmarcinkowski
added
the
DX
| * @throws \InvalidArgumentException | ||
| */ | ||
| public function formatAmount($amount, $currency = null, $decimal = false, $locale = null); | ||
| } |
There was a problem hiding this comment.
Missing blank line at the end of file ;)
|
@lchrusciel Hey Lukasz, i processed your comments. I also added a interface for CurrencyHelper. Would be weird if we only did the MoneyHelper and not the CurrencyHelper |
|
|
||
| /** | ||
| * Convert amount and format it! | ||
| * |
There was a problem hiding this comment.
I guess we could get rid of this comment since the method name already says this.
| public function __construct( | ||
| CurrencyContextInterface $currencyContext, | ||
| CurrencyConverterInterface $converter, | ||
| MoneyHelperInterface $moneyHelper |
There was a problem hiding this comment.
Moreover, could you put arguments in the same order as class fields? 😄
|
@lchrusciel does this need anything more to get merged? Let me know. |
|
It is good to go. Good job 👍 /cc @michalmarcinkowski |
|
Before we merge that, let's quickly discuss if we want interfaces for all helpers? I would say yes. |
michalmarcinkowski
added a commit
that referenced
this pull request
Mar 18, 2016
[MoneyBundle] [CurrencyBundle] Add interface for MoneyHelper and repl…
|
Thank you Axel! 👍 |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[MoneyBundle] [CurrencyBundle] Add interface for MoneyHelper and repl…
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[MoneyBundle] [CurrencyBundle] Add interface for MoneyHelper and repl…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ace specific typehinting to allow overrides