[ReportBundle] Remove sylius_data_fetcher prefix #4366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting, yesterday I was debugging issues we had with adding new reports to the reporting form in the Sylius admin area but couldn't understand the naming strategy that would allow it to work. By being more explicit, this will make things a lot more clearer, so 👍 /cc @timwebsterreiss |
michalmarcinkowski
added
the
DX
michalmarcinkowski
added a commit
that referenced
this pull request
Mar 2, 2016
[ReportBundle] Remove sylius_data_fetcher prefix
|
Thanks Nicolas 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove data_fetcher prefix