[RFC] Reduce code duplication in DI #439
Conversation
| $this->mapValidationGroupParameters($config['validation_groups'], $container); | ||
| } | ||
|
|
||
| if ($container->hasParameter('sylius.config.classes')) { |
There was a problem hiding this comment.
App name should be configurable (usefull if you make an app with ressource bundle)
There was a problem hiding this comment.
In that case you can do it on you own if you need it (note that this is replacement for Sylius bundles not custom ones):
list($config) = $this->configure($config, $container, self::CONFIGURE_LOADER | self::CONFIGURE_PARAMETERS | self::CONFIGURE_VALIDATORS);
$container->setParameter('my.own.namespace', array_merge($config['classes'], $container->getParameter('sylius.config.classes')));
|
👍 |
|
Awesome, but I guess you meant to "minimum". :D |
ghost
assigned 
|
@pjedrzejewski I think it's ready to go. |
[RFC] Reduce code duplication in DI
|
Nice! Thanks a lot Józef! Sometime later we could think about removing the duplication in Configuration classes, but this might be a bit more tricky as there are some differences, to be honest not sure if we can achieve lot there. |
|
@pjedrzejewski Can you exclude dir: |
[RFC] Reduce code duplication in DI
No description provided.