[Behat][Promotion] Removed softdeletable from Promotion #4401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $this->itemQuantityModifier->modify($item, 1); | ||
|
|
||
| $promotion->setUsed(1); | ||
| $order->addPromotion($promotion); |
There was a problem hiding this comment.
The promotion should be attached by orderRecalculator
NoResponseMate
force-pushed
the
harden-promotion
branch
2 times, most recently
from
ac4b91f
to
988f1de
Compare
|
This should fix #1799. |
11 tasks
|
Don't think so as I don't even touch that constraint. Seems more like #4047 will fix it by not letting you to delete it if the constraint is present. |
NoResponseMate
force-pushed
the
harden-promotion
branch
from
988f1de
to
db6e6c1
Compare
| /** | ||
| * Auto-generated Migration: Please modify to your needs! | ||
| */ | ||
| class Version20160305115221 extends AbstractMigration |
There was a problem hiding this comment.
Why do you have two migrations? Can you make only one?
There was a problem hiding this comment.
One's from the base branch => #4400
|
@NeverResponse I missed the fact that this scenario is only implemented at the domain level :) |
NoResponseMate
force-pushed
the
harden-promotion
branch
2 times, most recently
from
b9c6552
to
3669bc7
Compare
NoResponseMate
force-pushed
the
harden-promotion
branch
from
3669bc7
to
5a86e3d
Compare
| public function iShouldBeNotifiedOfFailure() | ||
| { | ||
| expect($this->sharedStorage->get('last_exception')) | ||
| ->toThrow(ForeignKeyConstraintViolationException::class) |
There was a problem hiding this comment.
toBeInstanceOf?
|
Rebase needed :) |
NoResponseMate
force-pushed
the
harden-promotion
branch
from
5a86e3d
to
6d81f4a
Compare
NoResponseMate
force-pushed
the
harden-promotion
branch
from
6d81f4a
to
4b43865
Compare
pjedrzejewski
pushed a commit
that referenced
this pull request
Mar 16, 2016
[Behat][Promotion] Removed softdeletable from Promotion
|
Thanks Jasiek! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #4400