Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Behat] [DX] Extract legacy tag #4434

Merged
merged 4 commits into from
Mar 9, 2016
Merged

Conversation

lchrusciel
Copy link
Member

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? yes
Related tickets partially #4410, fix #4436
License MIT
Doc PR

As @pamil said it would be better to extract legacy from tags. I know, that we are going to rid of this behats, but until that it can be really useful.

@pamil
Copy link
Contributor

pamil commented Mar 9, 2016

👍, but it would be nice to rename legacy tags from the plural form to the singular one, as we got @legacy @channels and @ui @channel now :)

@lchrusciel
Copy link
Member Author

@pamil good catch. The whole point of this PR it to enable running behats with tags

@pjedrzejewski pjedrzejewski added the DX Issues and PRs aimed at improving Developer eXperience. label Mar 9, 2016
@lchrusciel
Copy link
Member Author

Based on #4444

pjedrzejewski pushed a commit that referenced this pull request Mar 9, 2016
[Behat] [DX] Extract legacy tag
@pjedrzejewski pjedrzejewski merged commit bd842bb into Sylius:master Mar 9, 2016
@pjedrzejewski
Copy link
Member

Thanks @lchrusciel!

@lchrusciel lchrusciel deleted the retro-pr branch March 11, 2016 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Issues and PRs aimed at improving Developer eXperience.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Behat] [Taxonomy] Legacy taxonomy suit has broken tag
3 participants