Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] [Behat] [DX] Split behat services to different files #4441

Merged
merged 2 commits into from
Mar 11, 2016

Conversation

lchrusciel
Copy link
Member

Q A
Bug fix? yes
New feature? no
BC breaks? yes
Deprecations? no
Related tickets
License MIT
Doc PR

@lchrusciel lchrusciel changed the title [WIP] [Behat] [DX] Split behat services to different files [WIP] [RFC] [Behat] [DX] Split behat services to different files Mar 9, 2016
@pjedrzejewski pjedrzejewski added the DX Issues and PRs aimed at improving Developer eXperience. label Mar 9, 2016
@CoderMaggie
Copy link
Member

👍

@pjedrzejewski
Copy link
Member

What's the point of having 1 folder with 1 file?

@lchrusciel lchrusciel force-pushed the sevice-split branch 2 times, most recently from 51ec9a5 to a194800 Compare March 9, 2016 12:37
@lchrusciel lchrusciel changed the title [WIP] [RFC] [Behat] [DX] Split behat services to different files [RFC] [Behat] [DX] Split behat services to different files Mar 9, 2016
@lchrusciel lchrusciel force-pushed the sevice-split branch 3 times, most recently from 0589143 to 0893295 Compare March 9, 2016 18:50
@lchrusciel
Copy link
Member Author

Based on #4444

michalmarcinkowski added a commit that referenced this pull request Mar 11, 2016
[RFC] [Behat] [DX] Split behat services to different files
@michalmarcinkowski michalmarcinkowski merged commit 5234e47 into Sylius:master Mar 11, 2016
@michalmarcinkowski
Copy link
Contributor

Thanks Łukasz! 👍

@lchrusciel lchrusciel deleted the sevice-split branch March 11, 2016 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Issues and PRs aimed at improving Developer eXperience.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants