Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CoreBundle] Change enabled = 1 in ProductRepository to true #4496

Merged
merged 1 commit into from
Mar 15, 2016

Conversation

Niiko
Copy link

@Niiko Niiko commented Mar 14, 2016

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets -
License MIT
Doc PR -

I changed condition from value "1" (integer) to boolean (true).

Indeed, in mysql, there is no problem, but with more strict sgbd (as postgresql), that need to be casted.

@pjedrzejewski
Copy link
Member

👍

@Niiko
Copy link
Author

Niiko commented Mar 14, 2016

Check error on travis (php7) :

The command "etc/bin/test-packages" exited with 1.
3.01s$ etc/travis/prepare-javascript

Can't figure it out

@pamil
Copy link
Contributor

pamil commented Mar 14, 2016

@Niiko have a look at #4491, I'm going to report this bug to PHP and come up with another solution in the meanwhile.

@Niiko
Copy link
Author

Niiko commented Mar 14, 2016

oh, i saw it that morning but did not remember it for my problem.

Thanks to pointing me on that one.

michalmarcinkowski added a commit that referenced this pull request Mar 15, 2016
[CoreBundle] Change enabled = 1 in ProductRepository to true
@michalmarcinkowski michalmarcinkowski merged commit da2f6ed into Sylius:master Mar 15, 2016
@michalmarcinkowski
Copy link
Contributor

Thank you Nicolas! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants