[SearchBundle][ProductBundle] Add multilingual in elasticsearch engine and check on product availability

[Niiko]

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	yes
Deprecations?	no
Related tickets	fixes #4312
License	MIT
Doc PR	-

Here is my work on multilingual search with elasticsearch engine.

Here is my fos_elastica configuration

fos_elastica:
     clients:
         elasticsearch:
            servers:
                - { host: 127.0.0.1, port: 9200, logger: true }
     indexes:
         sylius:
             client: elasticsearch
             finder: ~
             settings:
                 analysis:
                    analyzer:
                        custom_search_analyzer:
                            type: custom
                            tokenizer: standard
                            filter   : [lowercase, asciifolding, synonym]
                        custom_index_analyzer:
                            type: custom
                            tokenizer: standard
                            filter   : [lowercase, asciifolding, synonym, custom_filter]
                    filter:
                        custom_filter:
                            type: nGram
                            min_gram: 1
                            max_gram: 20
                            token_chars: [letter, digit]
                        elision:
                            type:     elision
                            articles: [l, m, t, qu, n, s, j, d]
                        synonym:
                            type: synonym
                            synonyms: synonym.txt
             types:
                 product:
                     search_analyzer: custom_search_analyzer
                     index_analyzer: custom_index_analyzer
                     mappings:
                         id: { type: integer, index: not_analyzed }
                         name: { type: string }
                         description: { type: string }
                         shortDescription: { type: string }
                         slug: { type: string, index: not_analyzed }
                         translations:
                             type: nested
                             properties:
                                 locale: { type: string, index: not_analyzed }
                                 name: { type: string }
                                 metaKeywords: { type: string }
                                 metaDescription: { type: string }
                         masterVariant:
                             type: nested
                             properties:
                                 sku: { type: string }
                                 availableOn: { type: date, index: not_analyzed }
                                 availableUntil: { type: date }
                                 availableOnDemand: { type: boolean }
                                 presentation: { type: string }
                                 onHand: { type: integer, index: not_analyzed }
                                 onHold: { type: integer, index: not_analyzed }
                         variants:
                             type: nested
                             properties:
                                 sku: { type: string }
                                 availableOn: { type: date, index: not_analyzed }
                                 availableUntil: { type: date }
                                 availableOnDemand: { type: boolean }
                                 presentation: { type: string }
                                 onHand: { type: integer, index: not_analyzed }
                                 onHold: { type: integer, index: not_analyzed }
                         attributes:
                             type: nested
                             properties:
                                 value: { type: string }
                         channels: { type: string, index: not_analyzed }
                         taxons: { type: string, index: not_analyzed }
                         enabled: { type: boolean }
                     persistence:
                         driver: orm
                         model: Sylius\Component\Core\Model\Product
                         provider: ~
                         listener: ~
                         finder: ~

In order to work, the product type in fos_elastica config has to have properties : masterVariant, variants and enabled. So, if accepted, i can PR a minimum configuration for Sylius-docs.

I had also a check on availability of products with three checks :

• AvailableOn property of variant/masterVariant has to be lower than "now"
• AvailableUntil property of variant/masterVariant has to be null OR greater than "now"
• AvailableOnDemand property of variant/masterVariant has to be defined as true OR onHand property greater than 0

I have a question on last one, can we consider if onHand > 0 means product is available, or onHand - onHold > 0 ?

[okwinza]

Overall its 👍 but IMO the title is a bit misleading since there is more than just multilingual support.

[stloyd]

Shouldn't you add break; in this if? Cause now last one wins, with break first one wins.

[Niiko]

@okwinza You're right, changed title according to that

[stloyd]

This looks wrong, cause every index will overwrite the definition "over & over", so if you have two, it will write for both, but second one will overwrite definition of the first one.

[Niiko]

Right, i can add a check on that to add only one time.

[Edit] i refactor that definition to avoid extra loops, and wrong service definition (overwrite)

[pjedrzejewski]

Product bundle should not depend on SyliusSearchBundle. Can we somehow decouple it in this PR?

[lchrusciel]

Redundant comment

[lchrusciel]

Remove all this redundant comments

[Niiko]

@pjedrzejewski I can move prependElasticaProductListener to the core ? ElasticaProductListener too.

[Niiko]

ping @pjedrzejewski :)

[pjedrzejewski]

Looks good to me, we are going to change SearchBundle a lot, to simplify how it works. Could you move this from Core to SearchBundle? That's appropriate place I think.

[pjedrzejewski]

Thanks for your work!

[Niiko]

yes of course

[Niiko]

Done @pjedrzejewski ;)

[pjedrzejewski]

Great work Nicolas, you can't even imagine how helpful this PR is, opening and RFC in few minutes with explanation. :D Thanks!

[Niiko]

My pleasure :)

[pjedrzejewski]

See #4659, I rambled a bit, but I hope you get the idea. :D

[koemeet]

@Niiko After upgrading, this PR caused the following error to appear when deleting a product:

ActionRequestValidationException[Validation Failed: 1: id is missing;2: id is missing;]

Any idea? I am using the same mapping as you are using for a product. Using Elastic Search 1.7, what version are you using?

I've found that in the postRemove lifecycle hook, the objects id is null, I think this is causing the trouble.

[Niiko]

My bad, sorry