[Core] Order recalculation clean-up #4551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| function it_uses_order_recalculator_to_recalculate_order( | ||
| $orderRecalculator, |
There was a problem hiding this comment.
In this spec you have used Typehint for properties given in constructor, but here you haven't use this approach. Can you unified them?
Zales0123
force-pushed
the
order-recalculation-clean-ups
branch
4 times, most recently
from
8b1d59f
to
0372c52
Compare
| /** | ||
| * @param InteractiveLoginEvent $event | ||
| */ | ||
| public function recalculateCartWhileInteractiveLogin(InteractiveLoginEvent $event) |
There was a problem hiding this comment.
Since we're not using $event at all we can typehint to Symfony\Component\EventDispatcher\Event class and have one method for both events ;)
Zales0123
force-pushed
the
order-recalculation-clean-ups
branch
from
58f02a0
to
a805e28
Compare
|
👍 |
Also some fixes in specs.
Zales0123
force-pushed
the
order-recalculation-clean-ups
branch
from
a805e28
to
0e4a3d5
Compare
|
👍 |
|
Nice work Mateusz! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OrderRecalculatorOrderRecalculatorasOrderstate machine callbacksOrder