Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Behat] Clean up test parameters #4584

Merged
merged 3 commits into from
Mar 22, 2016

Conversation

Arminek
Copy link
Contributor

@Arminek Arminek commented Mar 21, 2016

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets -
License MIT

Clean up test parameters.

@Arminek Arminek changed the title Paypal review fixes [Behat] Clean up test parameters Mar 21, 2016
@pjedrzejewski pjedrzejewski added the Behat Issues and PRs aimed at improving Behat usage. label Mar 22, 2016
gateways:
paypal_express_checkout:
paypal_express_checkout_nvp:
username: EDITME
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should use "TEST".

pjedrzejewski pushed a commit that referenced this pull request Mar 22, 2016
[Behat] Clean up test parameters
@pjedrzejewski pjedrzejewski merged commit 572fe7a into Sylius:master Mar 22, 2016
@pjedrzejewski
Copy link
Member

Thanks Arek, nice work!

@pamil
Copy link
Contributor

pamil commented Mar 22, 2016

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Behat Issues and PRs aimed at improving Behat usage.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants