Add ability to change payment status #460
Conversation
| </td> | ||
| <td><span class="label label-success">{{ payment.state }}</span></td> | ||
| <td><span class="label {{ payment.state == 'completed' ? 'label-success' : (payment.state in ['checkout', 'processing', 'new'] ? 'label-info' : 'label-danger') }}">{{ payment.state }}</span></td> |
There was a problem hiding this comment.
I think this condition will be used several times (in Order list, etc.), shouldn't it be intesresting to put it in a macro?
There was a problem hiding this comment.
TBH. I didn't saw any point on using macro here... Order list use different states than payments so it can't be re-used (have a lookt at #459).
And if we support all those states the macro will need to have more lines than this file =)
There was a problem hiding this comment.
Nah, changed my mind =) It's friday =)
Just to clarify: as far as I can see it does not fix #457. |
| */ | ||
| public function getCurrencyName() | ||
| { | ||
| return Intl::getCurrencyBundle()->getCurrencyName($this->currency); |
There was a problem hiding this comment.
are there strict requirements with the intl extension version installed in the system? I remember something in the composer.lock changed when running the SystemRequirements.php when some things are not installed properly. Do you have any pointers on this? If you don't follow what i am saying then nvm 👶
Fixed wrong interface used in payment method model Fixed rendering of percent field in backend Created `state_label` macro for easier state rendering in backend
Add ability to change payment status
|
@makasim I am good with merging this, we will simply rework this once we introduce notifications/sync for payments. Thanks Joseph! |
| @@ -49,7 +49,7 @@ Feature: Exchange rates | |||
|
|
|||
| Scenario: Creating new exchange rate | |||
| Given I am on the exchange rate creation page | |||
| When I fill in "Currency" with "PLN" | |||
There was a problem hiding this comment.
thanks it may even seem to be useful for Warsaw :P
Additionally:
sylius_priceinstead ofsylius_money,Refs: #458.