Fix SyliusTaxationBundle when it's use as a standalone bundle #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we use _sortable: true instead of _sylius: { sortable: true }
the table is the same as the one in the WebBundle without the "zone" column
i used the same form which is in Macros/buttons.html.twig I have to use a trick to keep the same design for btn-group : http://stackoverflow.com/a/17603157/1731820
| <i class="icon-trash"></i> delete | ||
| </a> | ||
| <form action="{{ path('sylius_tax_category_delete', {'id': tax_category.id}) }}" method="post" class="btn-group inline pull-right"> | ||
| <input type="hidden" name="_method" value="DELETE" class="btn"><!-- fake sibling to left --> |
There was a problem hiding this comment.
what is this fake sibling to left comment?
There was a problem hiding this comment.
class and comment are useless i will remove that.
Without this input the button doesn't look like a button which is part of an btn-group
|
nice catches! 👶 |
the input hidden has to be before the button, to make the button part of an btn-group
stloyd
added a commit
that referenced
this pull request
Oct 26, 2013
…ndle Fix SyliusTaxationBundle when it's use as a standalone bundle
|
Thanks Benoit! Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when i was playing with the taxation bundle i've found a bunch of issue, here are the issue i have found:
sylius_tax_category_createandsylius_tax_rate_createare invalid, they contains an id parameters