[Admin] Locale unique code validation feature #4610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5,12 +5,11 @@ Feature: Locale unique code validation | |||
| I want to be prevented from adding a locale with an existing code | |||
|
|
|||
| Background: | |||
| Given the store is available in the Norwegian language | |||
| Given the store has locale "Norwegian" | |||
There was a problem hiding this comment.
What was wrong with the previous step? :)
Arminek
force-pushed
the
validating-locale
branch
from
7dd3c42
to
51afe24
Compare
| */ | ||
| public function iShouldNotBeAbleToChoose($name) | ||
| { | ||
| expect($this->createPage)->toThrow(ElementNotFoundException::class)->during('chooseName', [$name]); |
There was a problem hiding this comment.
We agreed to replace expect and catching exception with Assert and dedicated method on page that checks isSelectOptionAvailable or smth similar.
There was a problem hiding this comment.
isOptionAvailable ?
| When I choose Norwegian | ||
| And I try to add it | ||
| Then I should be notified that it is not possible | ||
| Given I want to create a new locale |
There was a problem hiding this comment.
to create add a new?
Arminek
force-pushed
the
validating-locale
branch
2 times, most recently
from
bf395a9
to
24a9a03
Compare
Arminek
force-pushed
the
validating-locale
branch
from
24a9a03
to
d92cecd
Compare
|
👍 |
| @@ -66,6 +66,7 @@ public function __construct( | |||
|
|
|||
| /** | |||
| * @Given I want to create a new locale | |||
There was a problem hiding this comment.
This should be removed and the below step should be used everywhere. Task for a separate PR.
|
Thanks Arek! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #4594