[Admin] Adding tax rate feature #4624

lchrusciel · 2016-03-25T10:46:25Z

Q	A
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Related tickets
License	MIT

pamil · 2016-03-25T10:47:38Z

features/taxation/managing_tax_rates/adding_tax_rate.feature

+        Given I want to create a new tax rate
+        When I specify its code as "EUROPEAN_UNION_SALES_TAX"
+        And I name it "European Union Sales Tax"
+        And It is defined for EU zone


pamil · 2016-03-25T10:48:47Z

features/taxation/managing_tax_rates/adding_tax_rate.feature

+        And It is defined for EU zone
+        And It defines tax rates for "Food and Beverage" tax category
+        And I its amount is "20%"
+        And I choose default calculator


Possibly the default calculator? /cc @TheMadeleine the articles master 🎉

pamil · 2016-03-25T10:52:02Z

features/taxation/managing_tax_rates/adding_tax_rate.feature

+        Given I want to create a new tax rate
+        When I specify its code as "EUROPEAN_UNION_SALES_TAX"
+        And I name it "European Union Sales Tax"
+        And it is defined for a EU zone


Anyway, we use "I specify its code", "I name it" but the "it is defined", "it defines", looks inconsistent.

Shouldn't it be "I define it for the EU zone", "I make it applicable for "Food and Beverage" tax category", etc.?

Thats was what I needed

pamil · 2016-03-25T10:54:52Z

features/taxation/managing_tax_rates/adding_tax_rate.feature

+    I want to add a new tax rate to the registry
+
+    Background:
+        Given there is "EU" zone containing all members of European Union


there is "EU" zone
it is defined for a EU zone

Let's either use the quotation marks or not :)

👍 Applied (edited)

Given there is a zone "EU" containing all members of the European Union

pamil · 2016-03-25T10:55:44Z

Looks good! 👍

CoderMaggie · 2016-03-25T11:04:24Z

features/taxation/managing_tax_rates/adding_tax_rate.feature

+        Given I want to create a new tax rate
+        When I specify its code as "EUROPEAN_UNION_SALES_TAX"
+        And I name it "European Union Sales Tax"
+        And I define it for a "EU" zone


for the "EU" zone
Cause it is already defined in the system and we know which one it is. :D

Zales0123 · 2016-03-28T20:40:53Z

src/Sylius/Behat/Context/Transform/TaxRateContext.php

+    {
+        $taxRate = $this->taxRateRepository->findOneBy(['name' => $taxRateName]);
+        if (null === $taxRate) {
+            throw new \InvalidArgumentException(sprintf('Tax category with name "%s" does not exist', $taxRateName));


Missing dot at the end of exception message.

pjedrzejewski · 2016-03-29T07:20:50Z

src/Sylius/Behat/Behaviour/ChoosesCalculator.php

+/**
+ * @author Łukasz Chruściel <lukasz.chrusciel@lakion.com>
+ */
+trait ChoosesCalculator


We do not have many other calculators, I think in this case trait is an overkill.

lchrusciel · 2016-03-29T08:09:13Z

src/Sylius/Behat/Context/Ui/Admin/ManagingTaxRateContext.php

+     */
+    public function iShouldBeNotifiedAboutSuccessfulEdition()
+    {
+        $this->updatePage->isCodeDisabled();


lchrusciel · 2016-03-29T08:59:32Z

src/Sylius/Bundle/AdminBundle/Resources/config/routing/tax_rate.yml

@@ -0,0 +1,16 @@
+sylius_admin_tax_category:


sylius_admin_tax_rate

michalmarcinkowski · 2016-03-29T09:10:19Z

features/taxation/managing_tax_rates/adding_tax_rate.feature

+        And I define it for the "European Union" zone
+        And I make it applicable for the "Food and Beverage" tax category
+        And I specify its amount as 20%
+        And I want to use the default tax calculator


And I ~~want to use~~ choose?

michalmarcinkowski · 2016-03-29T09:14:38Z

Nice work! 👍

pjedrzejewski · 2016-03-29T13:16:35Z

features/taxation/managing_tax_rates/editing_tax_rate.feature

@@ -0,0 +1,58 @@
+@managing_tax_rates
+Feature: Editing tax rate
+    In order to change tax classification of my products


In order to change taxes applied to orders

"taxes applied to products" will be more appropriate for me :)

pamil reviewed Mar 25, 2016
View reviewed changes

lchrusciel force-pushed the tax-rate-features branch from 1701cdc to 4a82c04 Compare March 25, 2016 10:48

pamil reviewed Mar 25, 2016
View reviewed changes

lchrusciel force-pushed the tax-rate-features branch 2 times, most recently from ba8b89b to 0148fa7 Compare March 25, 2016 10:50

pamil reviewed Mar 25, 2016
View reviewed changes

lchrusciel force-pushed the tax-rate-features branch 2 times, most recently from 1b173c9 to cda0c4c Compare March 25, 2016 10:54

pamil reviewed Mar 25, 2016
View reviewed changes

lchrusciel force-pushed the tax-rate-features branch from cda0c4c to f100cc8 Compare March 25, 2016 10:55

lchrusciel force-pushed the tax-rate-features branch from f100cc8 to 92c3969 Compare March 25, 2016 10:56

CoderMaggie reviewed Mar 25, 2016
View reviewed changes

pjedrzejewski added the Admin AdminBundle related issues and PRs. label Mar 25, 2016

lchrusciel force-pushed the tax-rate-features branch 8 times, most recently from cfba78c to 60af81a Compare March 25, 2016 14:26

Zales0123 reviewed Mar 28, 2016
View reviewed changes

pjedrzejewski reviewed Mar 29, 2016
View reviewed changes

lchrusciel force-pushed the tax-rate-features branch 3 times, most recently from 315ff32 to 694f094 Compare March 29, 2016 08:04

lchrusciel reviewed Mar 29, 2016
View reviewed changes

lchrusciel mentioned this pull request Mar 29, 2016

[Admin] Tax rate validation features #4637

Merged

lchrusciel force-pushed the tax-rate-features branch from 4fcbd22 to 260a650 Compare March 29, 2016 08:57

lchrusciel reviewed Mar 29, 2016
View reviewed changes

lchrusciel force-pushed the tax-rate-features branch from 260a650 to 17a5a60 Compare March 29, 2016 09:07

michalmarcinkowski reviewed Mar 29, 2016
View reviewed changes

lchrusciel added 3 commits March 29, 2016 11:19

[Admin] Adding tax rate feature

79d84d2

[Admin] Tax rate deletion feature

df83da6

[Admin] Tax rate edition feature

a97bfa3

lchrusciel force-pushed the tax-rate-features branch from 17a5a60 to 107f940 Compare March 29, 2016 09:19

[Admin] Tax rate unique code validation feature

1d34671

lchrusciel force-pushed the tax-rate-features branch from 107f940 to 1d34671 Compare March 29, 2016 09:57

[Admin] Tax rate additional edition scenarios

d69f5dd

michalmarcinkowski merged commit 07344da into Sylius:master Mar 29, 2016

lchrusciel deleted the tax-rate-features branch March 29, 2016 12:16

pjedrzejewski reviewed Mar 29, 2016
View reviewed changes

lchrusciel mentioned this pull request Mar 29, 2016

[DX] [Behat] Tax rate sematic fix #4641

Merged

michalmarcinkowski mentioned this pull request Apr 18, 2016

[Admin] Managing tax rates #4562

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Admin] Adding tax rate feature #4624

[Admin] Adding tax rate feature #4624

lchrusciel commented Mar 25, 2016

pamil Mar 25, 2016

pamil Mar 25, 2016

pamil Mar 25, 2016

lchrusciel Mar 25, 2016

pamil Mar 25, 2016

lchrusciel Mar 25, 2016

CoderMaggie Mar 25, 2016

pamil commented Mar 25, 2016

CoderMaggie Mar 25, 2016

Zales0123 Mar 28, 2016

pjedrzejewski Mar 29, 2016

lchrusciel Mar 29, 2016

lchrusciel Mar 29, 2016

michalmarcinkowski Mar 29, 2016

michalmarcinkowski commented Mar 29, 2016

pjedrzejewski Mar 29, 2016

michalmarcinkowski Mar 29, 2016

[Admin] Adding tax rate feature #4624

[Admin] Adding tax rate feature #4624

Conversation

lchrusciel commented Mar 25, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pamil commented Mar 25, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

michalmarcinkowski commented Mar 29, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment