[Metadata] Fix modifying metadata by serializing it early #4670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamil
force-pushed
the
metadata/fix-update
branch
from
165a694
to
818ac76
Compare
Metadata cannot be stored as `object` ORM type, because objects are compared (===) by reference, not by value, what means that changes would not be persisted. The only working way I have found is to store metadata as `text` type and serialize it on MetadataContainer::setMetadata() method call. However, after every metadata modification we have to use that method once again, if not - changes won't be persisted.
pamil
force-pushed
the
metadata/fix-update
branch
from
818ac76
to
0b9b9d2
Compare
|
Thank you Kamil! /cc @peteward |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metadata cannot be stored as
objectORM type, because objects arecompared (===) by reference, not by value, what means that changes
would not be persisted.
The only working way I have found is to store metadata as
texttype and serialize it on MetadataContainer::setMetadata() method
call. However, after every metadata modification we have to use that
method once again, if not - changes won't be persisted.