Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Semantic Ui] [RFC] Fix problematic dropdown generation #4704

Merged
merged 1 commit into from
Apr 11, 2016

Conversation

lchrusciel
Copy link
Member

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

@michalmarcinkowski michalmarcinkowski added Bug Fix UX Issues and PRs aimed at improving User eXperience. labels Apr 11, 2016
@pjedrzejewski
Copy link
Member

Could you elaborate on how this fixes the problem?

@lchrusciel
Copy link
Member Author

I just removed semantic wrapper on select tag. I looks similar to other fields, but it is not as pretty as it can be. But it is the simplest solution.
Pros:

  • Simple
  • Does not depend on any variables
  • Does not require any additional code
  • Super easy to maintain

Cons:

  • Could be prettier
  • Could be problematic if we decide to implement Multiple Search Selection

@pjedrzejewski pjedrzejewski merged commit cdea00e into Sylius:master Apr 11, 2016
@pjedrzejewski
Copy link
Member

🎉 Thanks Łukasz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UX Issues and PRs aimed at improving User eXperience.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants