[Admin][PaymentMethod] Payment method features #4742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSadee
force-pushed
the
admin-payment-method
branch
from
bbed6a7
to
14a0c23
Compare
|
|
||
| if (null === $paymentMethod) { | ||
| throw new \InvalidArgumentException('Cannot find payment method named %s', $name); | ||
| } |
There was a problem hiding this comment.
Assert::notNull
GSadee
force-pushed
the
admin-payment-method
branch
2 times, most recently
from
3b03e86
to
48eca50
Compare
GSadee
changed the title
GSadee
changed the title
GSadee
changed the title
| Given I want to create a new payment method | ||
| When I name it "Paypal Express Checkout" in "English (United States)" | ||
| And I specify its code as "PEC" | ||
| And I choose gateway "Paypal Express Checkout" |
There was a problem hiding this comment.
And I choose a "Paypal Express Checkout" gateway here and in the second scenario
GSadee
force-pushed
the
admin-payment-method
branch
from
48eca50
to
693c895
Compare
GSadee
changed the title
GSadee
force-pushed
the
admin-payment-method
branch
4 times, most recently
from
b424ebc
to
3ab2a7c
Compare
GSadee
changed the title
| I want to be able to browse payment methods | ||
|
|
||
| Background: | ||
| Given the store has a payment method "Offline" with a code "OFF" |
There was a problem hiding this comment.
If there's only one scenario, can we move the first two steps of the background into the scenario?
| @@ -42,6 +42,20 @@ public function __construct(Session $session, array $parameters, RouterInterface | |||
| /** | |||
| * {@inheritdoc} | |||
| */ | |||
| public function hasResourceValues(array $parameters) | |||
There was a problem hiding this comment.
Added in #4841, please rebase with master.
GSadee
force-pushed
the
admin-payment-method
branch
3 times, most recently
from
ead541b
to
7fa188c
Compare
| When I choose "Paypal Express Checkout" gateway | ||
| And I save my changes | ||
| Then I should be notified that it has been successfully edited | ||
| And this payment method gateway should be "paypal_express_checkout" |
There was a problem hiding this comment.
When I choose "Paypal Express Checkout" gateway
...
Then this payment method gateway should be "paypal_express_checkout"
?
There was a problem hiding this comment.
All right, I've had some kind of dejavu while writing this comment 🎉
GSadee
force-pushed
the
admin-payment-method
branch
from
7fa188c
to
f304238
Compare
GSadee
force-pushed
the
admin-payment-method
branch
from
f304238
to
1f3e1bb
Compare
|
Thank you Grzesiu and Arek, nice work guys! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially based on #4736