[Bug Fix] Added customer validator initializer to set canonical email #4747
Conversation
| @@ -208,6 +209,11 @@ | |||
| <argument type="service" id="sylius.repository.customer" /> | |||
| <tag name="validator.constraint_validator" alias="registered_user_validator" /> | |||
| </service> | |||
|
|
|||
| <service id="sylius.user.validator.customer_initializer" class="Sylius\Bundle\UserBundle\Validator\Initializer\CustomerInitializer"> | |||
There was a problem hiding this comment.
Should use the class parameter set above :)
There was a problem hiding this comment.
haha, wow, that is stupid..
|
Great, could you please squash it to a single commit? Thank you Steffen! |
|
@pjedrzejewski You can do it too now: https://github.com/blog/2141-squash-your-commits |
|
@stloyd For some reason it does not work, I get that Travis check is required and we should not disable that. |
| { | ||
| $customer->getEmail()->willReturn('sTeFfEn@gMaiL.CoM'); | ||
| $canonicalizer->canonicalize('sTeFfEn@gMaiL.CoM') | ||
| ->shouldBeCalled() |
There was a problem hiding this comment.
shouldBeCalled should be removed, willReturn is enough.
|
You have to click on merge and then you will be able to select if you want to squash it. |
|
@steffenbrem The problem is that I have configured Travis as required check, and this prevents me from squashing it via UI. :/ |
|
That is strange, I have two other projects with the same setup, also a CI check and enabled both merge commit + squash merging. Then I could simply click on But np, I will squash it 👍 |
… email canonical on initialisation. Customer object is now also validating against `emailCanonical` and uses `email` as it's error path.
koemeet
force-pushed
the
bugfix/customer-email-validation-canonical-4733
branch
from
4484227
to
9c5d944
Compare
|
Thanks Steffen! |
Added customer validator initializer that sets email canonical on initialisation. Customer object is now also validating against
emailCanonicaland usesemailas it's error path.