[Grid] Introduced grid datetime field type #4789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| /** @var \DateTime $value */ | ||
| $value = $this->dataExtractor->get($field, $data); | ||
| if (null === $value) { |
There was a problem hiding this comment.
Shouldn't we validate if $value is instance of \DateTime?
I would add Assert::isInstanceOf($value, \DateTime::class)
There was a problem hiding this comment.
Sure! I didn't add it, because I wasn't sure where we are now with fields validation... it would be good to validate format variable to be proper datetime format 😄 but for now - validation of value type 👍
Zales0123
force-pushed
the
datetime-field-type
branch
from
deecf3e
to
b7094aa
Compare
|
I thinks datetime should be intl/localizeddate with dateformat,timeformat. |
Zales0123
force-pushed
the
datetime-field-type
branch
from
b7094aa
to
cedbef1
Compare
Zales0123
force-pushed
the
datetime-field-type
branch
from
cedbef1
to
1b5d8b1
Compare
|
Thank you Mateusz! @liverbool Absolutely, we will add that in future PRs. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It could be useful for fields like
createdAtetc.