Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Behat][Notification] Flyweight pattern #4794

Merged
merged 1 commit into from
Apr 20, 2016
Merged

[Behat][Notification] Flyweight pattern #4794

merged 1 commit into from
Apr 20, 2016

Conversation

Arminek
Copy link
Contributor

@Arminek Arminek commented Apr 15, 2016

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

@pjedrzejewski pjedrzejewski added the Behat Issues and PRs aimed at improving Behat usage. label Apr 15, 2016
pamil
pamil reviewed Apr 15, 2016
View reviewed changes
src/Sylius/Behat/NotificationType.php
if (!isset(static::$types[$type])) {
static::$types[$type] = new self($type);

return static::$types[$type];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line can be removed :)

@Arminek Arminek force-pushed the notification-checker branch 2 times, most recently from bf8e55b to 8402632 Compare April 15, 2016 08:07
@pjedrzejewski pjedrzejewski merged commit d2198e2 into Sylius:master Apr 20, 2016
@pjedrzejewski
Copy link
Member

Thank you Arek!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Behat Issues and PRs aimed at improving Behat usage.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Arminek @pjedrzejewski @pamil