[Twig] Currency and Money helpers clean up #4798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lchrusciel
commented
Apr 15, 2016
lchrusciel
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
|
Wow, Travis feedback is as fast as it has never been before! 🎉 |
lchrusciel
force-pushed
the
currency-clean-up
branch
from
83df85c
to
2c2d825
Compare
pjedrzejewski
added
the
Enhancement
|
AmountFormatter vs. MoneyFormatter? Amount is quite wide term. |
| $this->shouldImplement(MoneyHelperInterface::class); | ||
| } | ||
|
|
||
| function it_allows_to_format_money_in_different_currencies( |
There was a problem hiding this comment.
Shouldn't it be divided into more sections:
- it formats money using default currency and locale if only amount is given
- it formats money using default currency if not given
- it formats money using default locale if not given
- it formats money using given currency and locale
|
@pjedrzejewski 👍 for MoneyFormatter |
lchrusciel
force-pushed
the
currency-clean-up
branch
2 times, most recently
from
4c11661
to
723240c
Compare
lchrusciel
force-pushed
the
currency-clean-up
branch
from
9c6f7f7
to
557d8db
Compare
|
👍 |
|
Thanks Łukasz, really nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.