[Registry] Added service registry context #4836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| </service> | ||
|
|
||
| <service id="sylius.registry.report.renderer" class="%sylius.registry.report.class%"> | ||
| <argument>Sylius\Component\Report\Renderer\RendererInterface</argument> | ||
| <argument>Renderer</argument> |
There was a problem hiding this comment.
s/Renderer/Report renderer
dantleech
changed the title
|
👍 |
|
Whilst I am here, what do you think about modifying the |
|
@dantleech Sounds great! |
dantleech
force-pushed
the
service_registry_context
branch
from
e805fec
to
d8c3d12
Compare
- Added additional argument to the service registry indicating the context in order to give more helpful exception messages. - Show available services in the "not found" exception message.
dantleech
force-pushed
the
service_registry_context
branch
from
d8c3d12
to
8d6a871
Compare
|
Updated. |
|
Thanks @dantleech! |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[Registry] Added service registry context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added additional argument to the service registry indicating the context in
order to give more helpful exception messages.
So instead of:
You get:
The context is optional in order to preserve BC (I would personally consider making it mandatory).