[ProductAttribute] Product attributes feature #4846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tuka217
commented
Apr 21, 2016
•
tuka217
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | - |
| License | MIT |
tuka217
changed the title
|
|
||
| Assert::true( | ||
| $this->indexPage->isResourceOnPage(['name' => $name]), | ||
| sprintf('The product attribute with name %s should appear on page, but it do not.', $name) |
| <h4 class="ui dividing header">{{ 'sylius.ui.configuration'|trans }}</h4> | ||
| <div class="ui segment configuration"> | ||
| {% if form.configuration is defined %} | ||
| {% for field in form.configuration %} |
There was a problem hiding this comment.
Maybe you could use {% for field in form.configuration if form.configuration is defined %}?
There was a problem hiding this comment.
Unfortunately I can't :(
tuka217
force-pushed
the
admin-attributes
branch
7 times, most recently
from
7f849e4
to
9b0679b
Compare
tuka217
changed the title
| templates: | ||
| form: SyliusAdminBundle:ProductAttribute:_form.html.twig | ||
| requirements: | ||
| type: text|textarea|checkbox|integer|percent|datetime|date |
There was a problem hiding this comment.
I know this will create a bug, but we should not restrict it here, because otherwise we prevent the developer from introducing his own types.
…t attribute [Behat] Implementation of scenarios
tuka217
force-pushed
the
admin-attributes
branch
from
9b0679b
to
2a2e1ab
Compare
tuka217
force-pushed
the
admin-attributes
branch
from
2a2e1ab
to
7659000
Compare
|
Nice work Ania, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.