[VariationBundle] Added option repository #4856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GSadee
commented
Apr 23, 2016
GSadee
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
8 tasks
pjedrzejewski
added
the
Enhancement
| @@ -115,7 +116,7 @@ private function addClassesSection(ArrayNodeDefinition $node) | |||
| ->scalarNode('model')->isRequired()->cannotBeEmpty()->end() | |||
| ->scalarNode('interface')->isRequired()->cannotBeEmpty()->end() | |||
| ->scalarNode('controller')->defaultValue(ResourceController::class)->cannotBeEmpty()->end() | |||
| ->scalarNode('repository')->cannotBeEmpty()->end() | |||
| ->scalarNode('repository')->defaultValue(OptionRepository::class)->cannotBeEmpty()->end() | |||
There was a problem hiding this comment.
This couples it to Doctrine ORM, we do not specify driver specific repositories in Configuration class. You should load a driver file, which will contain the repo. With VariationBundle it can be a bit more complex, because we generate the services, but I am pretty sure @lchrusciel will be able to help here because we have figured out this with ArchetypeBundle.
GSadee
force-pushed
the
option-repository
branch
4 times, most recently
from
e8cc406
to
4212574
Compare
| /** | ||
| * @author Grzegorz Sadowski <grzegorz.sadowski@lakion.com> | ||
| */ | ||
| interface OptionRepositoryInterface |
There was a problem hiding this comment.
Should extend Sylius\Component\Resource\Repository\RepositoryInterface
GSadee
force-pushed
the
option-repository
branch
from
4212574
to
41356e9
Compare
|
Thank you Grzesiu! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.