Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement basic state resolver and shipping states for order #487

Merged
merged 4 commits into from
Nov 9, 2013

Conversation

pjedrzejewski
Copy link
Member

This introduces order state resolver service which updates the overall shipping / payment (not yet) states of the order.

@winzou
Copy link
Contributor

winzou commented Oct 31, 2013

Sorry I did comments on #489 instead.


if (!$order instanceof OrderInterface) {
throw new \InvalidArgumentException(
'Order inventory listener requires event subjct to be instance of "Sylius\Bundle\CoreBundle\Model\OrderInterface"'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subject typo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be an instance

@stloyd
Copy link
Contributor

stloyd commented Nov 1, 2013

Paweł Jędrzejewski and others added 4 commits November 9, 2013 09:43
pjedrzejewski pushed a commit that referenced this pull request Nov 9, 2013
Implement basic state resolver and shipping states for order
@pjedrzejewski pjedrzejewski merged commit e394595 into master Nov 9, 2013
@pjedrzejewski pjedrzejewski deleted the order-states branch November 9, 2013 21:35
@JRomeoSalazar
Copy link
Contributor

At the file "src/Sylius/Bundle/WebBundle/Resources/views/Backend/Order/macros.html.twig" line 17 there is an error I think. 'shippingState' instead of 'shipmentState' due to this PR changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants