-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement basic state resolver and shipping states for order #487
Conversation
Sorry I did comments on #489 instead. |
|
||
if (!$order instanceof OrderInterface) { | ||
throw new \InvalidArgumentException( | ||
'Order inventory listener requires event subjct to be instance of "Sylius\Bundle\CoreBundle\Model\OrderInterface"' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
subject typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be an instance
Conflicts: src/Sylius/Bundle/ShippingBundle/Model/ShipmentInterface.php
Implement basic state resolver and shipping states for order
At the file "src/Sylius/Bundle/WebBundle/Resources/views/Backend/Order/macros.html.twig" line 17 there is an error I think. 'shippingState' instead of 'shipmentState' due to this PR changes. |
This introduces order state resolver service which updates the overall shipping / payment (not yet) states of the order.