Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Elastica product listener orphaned objects throws error #4889

Merged

Conversation

koemeet
Copy link
Contributor

@koemeet koemeet commented Apr 27, 2016

Q A
Bug fix? yes
New feature? no
BC breaks? no
Related tickets
License MIT

Fixes bug where a "product aware" object that has it's product detached (such as an attribute value) throwed an error when updating ES product index.

If you would for example remove an attribute value object from a product and save that product the listener will fail, since the ProductAttributeValue has been orphaned (ready to be deleted).

…ed (such as an attribute value) throwed an error when updating ES product index.
@pjedrzejewski pjedrzejewski merged commit 0319002 into Sylius:master Apr 27, 2016
@pjedrzejewski
Copy link
Member

Thanks Steffen!

@koemeet koemeet deleted the bugfix/search-product-listener-orphan-fix branch April 27, 2016 14:56
@koemeet koemeet restored the bugfix/search-product-listener-orphan-fix branch September 16, 2016 13:54
@koemeet koemeet deleted the bugfix/search-product-listener-orphan-fix branch September 16, 2016 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants