[Setup][Order] Fixed names of some steps in OrderContext #4943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GSadee
commented
May 4, 2016
GSadee
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Related tickets | |
| License | MIT |
| */ | ||
| public function theCustomerPlacedAnOrder(CustomerInterface $customer, $orderNumber) | ||
| public function aCustomerPlacedAnOrder(CustomerInterface $customer, $orderNumber) |
There was a problem hiding this comment.
Should we write articles in camelCased method names? customerPlacedOrder instead of aCustomerPlacedAnOrder and customerBoughtSingleProduct instead of theCustomerBoughtASingleProduct looks cleaner to me. Typing $this->custom... will show me all actions that customer may perform, without thinking if I should look at aCustom... or theCustom....
Moreover, we do not know in the method if it is a new customer or the one defined earlier, because it is the responsibility of parameters transformers to provide us customer instance in any case. We just get customer, nothing more or less.
GSadee
force-pushed
the
setup-order-context-fixes
branch
from
1b0e2f3
to
496489a
Compare
|
Thanks Grzesiu! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.