Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[payum] lower php version. #503

Merged

Conversation

makasim
Copy link
Contributor

@makasim makasim commented Oct 31, 2013

it fixes #488

@@ -47,8 +47,8 @@
"twig/extensions": "1.0.*",
"white-october/pagerfanta-bundle": "1.0.*@dev",
"omnipay/omnipay": "1.0.*",
"payum/payum": "0.6.*",
"payum/payum-bundle": "0.6.*",
"payum/payum": "~0.6.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm with ~0.6 you don't need to be updating these

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if I get ~ correctly ~0.6 means >=0.6.0,<1.0.0 where ~0.6.3 means >=0.6.3,<0.7.0

doc: http://getcomposer.org/doc/01-basic-usage.md#next-significant-release-tilde-operator-

@makasim
Copy link
Contributor Author

makasim commented Nov 3, 2013

restarted travis build hope it pass now.

@makasim
Copy link
Contributor Author

makasim commented Nov 4, 2013

@pjedrzejewski is the master stable? I dont think this PR has some thing that can fail.

@makasim
Copy link
Contributor Author

makasim commented Nov 7, 2013

@pjedrzejewski ping.

pjedrzejewski pushed a commit that referenced this pull request Nov 7, 2013
@pjedrzejewski pjedrzejewski merged commit a7372f7 into Sylius:master Nov 7, 2013
@pjedrzejewski
Copy link
Member

Travis is failing because of the bug in our script, it should be fine. :)

@pjedrzejewski
Copy link
Member

fixed bug*

@makasim makasim deleted the payum-lower-php-version branch November 7, 2013 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP min version bumped to 5.3.9 by Payum integration
3 participants