[ResourceBundle] Default Form builder for PHPCR-ODM #5039

dantleech · 2016-05-16T10:14:30Z

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
License	MIT

This PR adds a DefaultFormBuilder for the PHPCR-ODM resource.

In addition, because of the tree nature of PHPCR I have added three event
listeners which: handle the default parent path, resolve name conflcits and
remove invalid characters from the node name.

These are configured in the resource config:

    resources:
        acme.post: 
            driver: doctrine/phpcr-odm,
            classes:
                model: Acme\Document\Post
            options:
                default_parent_path: /cms/foobar # set the parent path if none is provided
                autocreate: false                # autocreate non-existing parent paths
                force: false                     # always set the parent path.
                name_resolver: true              # resolve name conflcits
                name_filter: true                # filter invalid characters

dantleech · 2016-05-16T10:20:36Z

src/Sylius/Bundle/ResourceBundle/DependencyInjection/Driver/Doctrine/DoctrinePHPCRDriver.php

+                'autocreate' => false,
+            ],
+            $metadata->hasParameter('options') ? $metadata->getParameter('options') : []
+        );


Would be nice to have options handled in some way that provided defaults and disallowed specification of non-valid keys.

dantleech · 2016-05-16T10:21:32Z

src/Sylius/Bundle/ResourceBundle/Doctrine/ODM/PHPCR/Form/Builder/DefaultFormBuilder.php

+    {
+        $classMetadata = $this->documentManager->getClassMetadata($metadata->getClass('model'));
+
+        // the field mappings should only contain standard value mappings


.. but sadly they don't ...

dantleech · 2016-05-16T10:27:11Z

src/Sylius/Bundle/ResourceBundle/DependencyInjection/Driver/Doctrine/DoctrinePHPCRDriver.php

+        $defaultFormBuilderDefinition->setArguments([
+            new Reference($metadata->getServiceId('manager')),
+            $options['default_parent_path'],
+            $options['autocreate']


There options only apply to the DefaultFormBuilder - which means that as soon as the user creates a custom form type these values become meaningless.

I wonder if these should be implemented as a PHPCR-ODM EventSubscribers instead.

dantleech · 2016-05-17T10:21:21Z

src/Sylius/Bundle/ResourceBundle/DependencyInjection/Driver/Doctrine/AbstractDoctrineDriver.php

@@ -17,6 +17,8 @@
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Definition;
 use Symfony\Component\DependencyInjection\Reference;
+use Sylius\Bundle\ResourceBundle\Doctrine\ODM\PHPCR\EventListener\Subscriber\NameResolverListener;
+use Sylius\Bundle\ResourceBundle\Doctrine\ODM\PHPCR\EventListener\Subscriber\DefaultPathListener;


dantleech · 2016-05-19T09:26:29Z

src/Sylius/Bundle/ResourceBundle/DependencyInjection/Driver/Doctrine/DoctrinePHPCRDriver.php

+            [
+                'default_parent_path' => null,
+                'autocreate' => false,
+                'force' => false,


rename to force_default_parent

dantleech · 2016-05-19T09:28:20Z

Updated, refactored to have an event listener-per-resource and added specs. This is now ready-for-review.

- Automatic generation of form - Option to specify default path - Resolve node name conflicts and normalize the path

dantleech · 2016-05-28T10:13:57Z

ping @pjedrzejewski

pjedrzejewski · 2016-06-02T18:24:46Z

@dantleech Looks good to me! Waiting for last tweaks and it is good to go. 👍 Nice work! We will be using all the PHPCR stuff for grids and resources in the new admin, your work has been a huge help!

dantleech · 2016-06-03T07:52:15Z

src/Sylius/Bundle/ResourceBundle/DependencyInjection/Driver/Doctrine/DoctrinePHPCRDriver.php

+        if ($diff = array_diff(array_keys($metadataOptions), array_keys($defaultOptions))) {
+            throw new InvalidArgumentException(sprintf(
+                'Unknown PHPCR-ODM configuration options: "%s"',
+                implode('", "', $diff)


Renamed the options and added this sanity check.

pjedrzejewski · 2016-06-03T09:27:26Z

Great work, thank you Dan! 👍

dantleech · 2016-06-03T09:41:34Z

Thanks! I am currently working on a CMS which uses only Sylius Resource/Grid + Symfony CMF, with the aim of providing an alternative to Sonata Admin. So expect more contributions :)

[ResourceBundle] Default Form builder for PHPCR-ODM

dantleech reviewed May 16, 2016
View reviewed changes

dantleech force-pushed the phpcrodm_form_builder branch from ee4591d to d50d44c Compare May 16, 2016 10:21

dantleech reviewed May 16, 2016
View reviewed changes

dantleech changed the title ~~[ResourceBundle][WIP]Form builder for PHPCR-ODM~~ [ResourceBundle][WIP] Default Form builder for PHPCR-ODM May 16, 2016

dantleech reviewed May 16, 2016
View reviewed changes

pjedrzejewski added the New Feature label May 16, 2016

dantleech reviewed May 17, 2016
View reviewed changes

dantleech force-pushed the phpcrodm_form_builder branch from 8d9f822 to 31979b0 Compare May 19, 2016 09:24

dantleech changed the title ~~[ResourceBundle][WIP] Default Form builder for PHPCR-ODM~~ [ResourceBundle] Default Form builder for PHPCR-ODM May 19, 2016

dantleech reviewed May 19, 2016
View reviewed changes

dantleech added 4 commits May 28, 2016 11:01

Form builder for PHPCR-ODM

0d988d9

- Automatic generation of form - Option to specify default path - Resolve node name conflicts and normalize the path

Refactored to use resource events

15ce13d

Spec for DefaultParentListener

a4e4d44

Listener specs

01d745b

dantleech force-pushed the phpcrodm_form_builder branch from 31979b0 to 325632d Compare May 28, 2016 10:11

michalmarcinkowski added the Awaiting Review label May 29, 2016

dantleech force-pushed the phpcrodm_form_builder branch from 325632d to 3fc5987 Compare May 29, 2016 14:11

Allow definitions with no options?

d356423

dantleech force-pushed the phpcrodm_form_builder branch from 3fc5987 to d356423 Compare June 3, 2016 07:50

dantleech reviewed Jun 3, 2016
View reviewed changes

pjedrzejewski merged commit 62aa667 into Sylius:master Jun 3, 2016

pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019

Merge pull request Sylius#5039 from dantleech/phpcrodm_form_builder

c2b59c5

[ResourceBundle] Default Form builder for PHPCR-ODM

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ResourceBundle] Default Form builder for PHPCR-ODM #5039

[ResourceBundle] Default Form builder for PHPCR-ODM #5039

dantleech commented May 16, 2016 •

edited

Loading

dantleech May 16, 2016

dantleech May 16, 2016

dantleech May 16, 2016

dantleech May 17, 2016

dantleech May 19, 2016

dantleech commented May 19, 2016

dantleech commented May 28, 2016

pjedrzejewski commented Jun 2, 2016

dantleech Jun 3, 2016

pjedrzejewski commented Jun 3, 2016

dantleech commented Jun 3, 2016

[ResourceBundle] Default Form builder for PHPCR-ODM #5039

[ResourceBundle] Default Form builder for PHPCR-ODM #5039

Conversation

dantleech commented May 16, 2016 • edited Loading

dantleech May 16, 2016

Choose a reason for hiding this comment

dantleech May 16, 2016

Choose a reason for hiding this comment

dantleech May 16, 2016

Choose a reason for hiding this comment

dantleech May 17, 2016

Choose a reason for hiding this comment

dantleech May 19, 2016

Choose a reason for hiding this comment

dantleech commented May 19, 2016

dantleech commented May 28, 2016

pjedrzejewski commented Jun 2, 2016

dantleech Jun 3, 2016

Choose a reason for hiding this comment

pjedrzejewski commented Jun 3, 2016

dantleech commented Jun 3, 2016

dantleech commented May 16, 2016 •

edited

Loading