Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Order] Cleanups in Order component #5057

Merged
merged 1 commit into from
May 18, 2016
Merged

[Order] Cleanups in Order component #5057

merged 1 commit into from
May 18, 2016

Conversation

michalmarcinkowski
Copy link
Contributor

@michalmarcinkowski michalmarcinkowski commented May 18, 2016 •
edited
Loading

Q A
Bug fix? no
New feature? no
BC breaks? yes
Related tickets
License MIT
  • Removed clearAdjustments method from AdjustableInterface (it is not used anywhere and shouldn't. I don't see any use case where we would want to remove all adjustments regardless of type)
  • Removed getTotalItems method from OrderInterface (it's not used and it's deprecated)
  • Removed redundant check for isLocked on adjustment in removeAdjustments methods

@michalmarcinkowski michalmarcinkowski changed the title [Order] Initial cleanups [WIP] [Order] Initial cleanups May 18, 2016
@pjedrzejewski pjedrzejewski added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). BC Break PRs introducing BC breaks (do not even try to merge). labels May 18, 2016
@michalmarcinkowski michalmarcinkowski changed the title [WIP] [Order] Initial cleanups [Order] Initial cleanups May 18, 2016
@pjedrzejewski
Copy link
Member

Looks good to me, but could you add a meaningful commit message? Thanks!

@michalmarcinkowski
Copy link
Contributor Author

Couldn't find anything more clear. Hope it's fine now :)

@michalmarcinkowski michalmarcinkowski changed the title [Order] Initial cleanups [Order] Cleanups in Order component May 18, 2016
@pjedrzejewski pjedrzejewski merged commit d435ff9 into Sylius:master May 18, 2016
@pjedrzejewski
Copy link
Member

Thanks Michał!

@michalmarcinkowski michalmarcinkowski deleted the initial-order-component-cleanup branch May 18, 2016 22:40
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
Merge pull request Sylius#5057 from michalmarcinkowski/initial-order-…
530ef23 
…component-cleanup

[Order] Cleanups in Order component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BC Break PRs introducing BC breaks (do not even try to merge). Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michalmarcinkowski @pjedrzejewski