[Admin] Product variant features #5068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $this->addSql('DROP INDEX fulltext_search_idx ON sylius_search_index'); | ||
| $this->addSql('CREATE INDEX fulltext_search_idx ON sylius_search_index (item_id)'); | ||
| $this->addSql('DROP INDEX IDX_A29B523F9038C4 ON sylius_product_variant'); | ||
| $this->addSql('ALTER TABLE sylius_product_variant ADD code VARCHAR(255) NOT NULL, DROP sku'); |
There was a problem hiding this comment.
If you're determined to make this change then I suggest renaming the field to help people upgrading:
ALTER TABLE sylius_product_variant CHANGE sku code VARCHAR(255) NUL NULL
I still think it's a bad change.
People will confused Product.code and ProductVariant.code.
lchrusciel
force-pushed
the
product-variant-features
branch
4 times, most recently
from
5dd289b
to
f80d2e7
Compare
lchrusciel
changed the title
lchrusciel
force-pushed
the
product-variant-features
branch
5 times, most recently
from
b5c084b
to
acf3fca
Compare
| @@ -0,0 +1,21 @@ | |||
| @managing_product_variants | |||
| Feature: Adding a new product variant | |||
| In order to extend my merchandise | |||
There was a problem hiding this comment.
In order to sell different variations of a single product
lchrusciel
force-pushed
the
product-variant-features
branch
from
acf3fca
to
c83d22e
Compare
| Scenario: Browsing product variants in store | ||
| When I want to view all variants of this product | ||
| Then I should see 1 variant in the list | ||
|
|
lchrusciel
force-pushed
the
product-variant-features
branch
2 times, most recently
from
fd3feef
to
195f08d
Compare
| } | ||
|
|
||
| /** | ||
| * @Given /^I want to create a new product variant for (this product)$/ |
There was a problem hiding this comment.
I want to create a new variant of this product
lchrusciel
force-pushed
the
product-variant-features
branch
from
195f08d
to
f13081e
Compare
| - sylius.behat.context.transform.shipping_method | ||
| - sylius.behat.context.transform.addressing | ||
|
|
||
|
|
lchrusciel
force-pushed
the
product-variant-features
branch
2 times, most recently
from
bf4d2b1
to
4edc47f
Compare
lchrusciel
force-pushed
the
product-variant-features
branch
6 times, most recently
from
d62c6e5
to
321d743
Compare
| */ | ||
| public function iDeleteTheVariantOfProduct(ProductVariantInterface $productVariant) | ||
| { | ||
| $this->iWantToViewAllVariantsOfThisProduct($productVariant->getObject()); |
lchrusciel
force-pushed
the
product-variant-features
branch
from
321d743
to
c3789c9
Compare
lchrusciel
force-pushed
the
product-variant-features
branch
from
c3789c9
to
accb94d
Compare
lchrusciel
force-pushed
the
product-variant-features
branch
from
accb94d
to
ba8a36a
Compare
|
Thank you Łukasz! Good job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SKU removal will be also a part of this PR. SKU will be replaced by code, which is immutable.
Based on #4947