[Admin] Add single channel dashboard #5086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pjedrzejewski
force-pushed
the
admin/dashboard-prototype
branch
from
91f687f
to
9f31aaa
Compare
| And then 2 more customers have placed 2 orders for total of "€459.00" | ||
| When I open administration dashboard | ||
| Then I should see 6 new orders | ||
| And I should see 6 new customers |
There was a problem hiding this comment.
3 customers + 2 customers != 6 customers (I know there's also an admin, but it seems werid)
There was a problem hiding this comment.
Yes, but that's the flaw in our entire app, so I have no other way currently. :)
|
The context of "new" customers and orders seems weird to me, as there's no such thing in code right now. |
|
@pamil Yeah, I noticed that too, but I think it is not worth removing it, as I will add per channel / date filtering for this dashboard, so both provider interface and the logic will change. :) |
| * | ||
| * @return int | ||
| */ | ||
| private function getPriceFromString($price) |
There was a problem hiding this comment.
Do we really need this method? It is context, so why can't we use a lexical context?
pjedrzejewski
force-pushed
the
admin/dashboard-prototype
branch
2 times, most recently
from
b45a33a
to
084228d
Compare
pjedrzejewski
force-pushed
the
admin/dashboard-prototype
branch
from
084228d
to
2861261
Compare
|
Looks nice! Please apply @lchrusciel comments in a separate PR 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo:
Future improvements (got the template - see first commit):