-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add description to promotion adjustments #512
Conversation
Currently promotion adjustments don't have a description. This PR makes it possible to pass Promotion descriptions to these adjustments.
agree, that was missing |
@Richtermeister just to know, do you use Sylius/Sylius or Sylius/Standard atm to build your shop ? |
@jjanvier I just switched to Sylius/Standard-Edition. Had some initial issues with it, but nothing major. I have all my app code in bundles so it's pretty easy to switch back & forth. |
Add description to promotion adjustments
Looks good, thanks! |
This should be reverted... The "description" is very specific to the adjustments. For example, if you create an action which adds a product to cart, it becomes useless. Much better would be to add a configuration field "description" to the action configuration forms. HERE. This way we can avoid changing the interface. |
@pjedrzejewski Yeah, I was wondering about that as well. Will adjust and resubmit. |
@Richtermeister Thanks! :) |
I see emphasis is now on the S/SE, can someone reiterate here please what is the main difference? I was using S/S all along without problems. (S = Sylius) |
@cordoval SE pulls in Sylius code into vendors via composer so you can customize and version control the overall project without colliding with Sylius development. Does that answer your question? |
so are we doing subtree splits and decoupling them to be sourced into S/SE? |
@Richtermeister Have you started anything on this or should I take care of it? (no problem at all, I just want to restore previous interface) |
@pjedrzejewski Sorry, I have not started anything yet, so please go ahead. |
Currently promotion adjustments don't have a description.
This PR makes it possible to pass Promotion descriptions to these adjustments.