Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description to promotion adjustments #512

Merged
merged 1 commit into from
Nov 1, 2013

Conversation

Richtermeister
Copy link
Contributor

Currently promotion adjustments don't have a description.
This PR makes it possible to pass Promotion descriptions to these adjustments.

Currently promotion adjustments don't have a description.
This PR makes it possible to pass Promotion descriptions to these adjustments.
@jjanvier
Copy link
Contributor

jjanvier commented Nov 1, 2013

agree, that was missing

@jjanvier
Copy link
Contributor

jjanvier commented Nov 1, 2013

@Richtermeister just to know, do you use Sylius/Sylius or Sylius/Standard atm to build your shop ?

@Richtermeister
Copy link
Contributor Author

@jjanvier I just switched to Sylius/Standard-Edition. Had some initial issues with it, but nothing major. I have all my app code in bundles so it's pretty easy to switch back & forth.

stloyd added a commit that referenced this pull request Nov 1, 2013
Add description to promotion adjustments
@stloyd stloyd merged commit cfe987f into Sylius:master Nov 1, 2013
@stloyd
Copy link
Contributor

stloyd commented Nov 1, 2013

Looks good, thanks!

@Richtermeister Richtermeister deleted the promotion-descriptions branch November 1, 2013 22:31
@pjedrzejewski
Copy link
Member

This should be reverted... The "description" is very specific to the adjustments. For example, if you create an action which adds a product to cart, it becomes useless. Much better would be to add a configuration field "description" to the action configuration forms. HERE.

This way we can avoid changing the interface.

@Richtermeister
Copy link
Contributor Author

@pjedrzejewski Yeah, I was wondering about that as well. Will adjust and resubmit.

@Richtermeister Richtermeister restored the promotion-descriptions branch November 2, 2013 16:34
@pjedrzejewski
Copy link
Member

@Richtermeister Thanks! :)

@cordoval
Copy link
Contributor

cordoval commented Nov 4, 2013

I see emphasis is now on the S/SE, can someone reiterate here please what is the main difference? I was using S/S all along without problems. (S = Sylius)

@Richtermeister
Copy link
Contributor Author

@cordoval SE pulls in Sylius code into vendors via composer so you can customize and version control the overall project without colliding with Sylius development. Does that answer your question?

@cordoval
Copy link
Contributor

cordoval commented Nov 4, 2013

so are we doing subtree splits and decoupling them to be sourced into S/SE?
I did know this but I guess did not get the idea at first if so.

@pjedrzejewski
Copy link
Member

@Richtermeister Have you started anything on this or should I take care of it? (no problem at all, I just want to restore previous interface)

@Richtermeister
Copy link
Contributor Author

@pjedrzejewski Sorry, I have not started anything yet, so please go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants