Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shop] Integrate latest templates #5138

Merged
merged 15 commits into from
Jun 14, 2016

Conversation

pjedrzejewski
Copy link
Member

@pjedrzejewski pjedrzejewski commented May 29, 2016

Q A
Bug fix? no
New feature? yes
BC breaks? no
Related tickets -
License MIT

@pjedrzejewski pjedrzejewski added UX Issues and PRs aimed at improving User eXperience. Shop ShopBundle related issues and PRs. labels May 29, 2016
@@ -0,0 +1,6 @@
<div class="ui fluid vertical menu">
<div class="header item">My account</div>
Copy link
Contributor

@michalmarcinkowski michalmarcinkowski May 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sylius.ui.my_account should be used.

@pjedrzejewski pjedrzejewski force-pushed the ui/shop-integration branch 3 times, most recently from b1c4304 to b993600 Compare June 9, 2016 18:30
@pjedrzejewski pjedrzejewski force-pushed the ui/shop-integration branch 4 times, most recently from fa62a6c to cf46306 Compare June 12, 2016 15:36
@pjedrzejewski pjedrzejewski changed the title [WIP][Shop] Integrate latest templates [Shop] Integrate latest templates Jun 12, 2016
@@ -58,8 +58,14 @@ security:
check_path: sylius_shop_login_check
failure_path: sylius_shop_login
default_target_path: sylius_shop_homepage
use_forward: false
use_forward: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be reverted.

@pjedrzejewski pjedrzejewski force-pushed the ui/shop-integration branch 2 times, most recently from f807680 to f31ea3c Compare June 14, 2016 08:33
@michalmarcinkowski michalmarcinkowski merged commit 5af878b into Sylius:master Jun 14, 2016
@michalmarcinkowski
Copy link
Contributor

Great work Paweł! 👍

pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Shop ShopBundle related issues and PRs. UX Issues and PRs aimed at improving User eXperience.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants