-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Shop] Integrate latest templates #5138
Merged
michalmarcinkowski
merged 15 commits into
Sylius:master
from
pjedrzejewski:ui/shop-integration
Jun 14, 2016
Merged
[Shop] Integrate latest templates #5138
michalmarcinkowski
merged 15 commits into
Sylius:master
from
pjedrzejewski:ui/shop-integration
Jun 14, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pjedrzejewski
commented
May 29, 2016
•
edited
Loading
edited
Q | A |
---|---|
Bug fix? | no |
New feature? | yes |
BC breaks? | no |
Related tickets | - |
License | MIT |
pjedrzejewski
added
UX
Issues and PRs aimed at improving User eXperience.
Shop
ShopBundle related issues and PRs.
labels
May 29, 2016
pjedrzejewski
force-pushed
the
ui/shop-integration
branch
from
May 29, 2016 20:17
dac6444
to
5941755
Compare
@@ -0,0 +1,6 @@ | |||
<div class="ui fluid vertical menu"> | |||
<div class="header item">My account</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sylius.ui.my_account
should be used.
pjedrzejewski
force-pushed
the
ui/shop-integration
branch
3 times, most recently
from
June 9, 2016 18:30
b1c4304
to
b993600
Compare
pjedrzejewski
force-pushed
the
ui/shop-integration
branch
4 times, most recently
from
June 12, 2016 15:36
fa62a6c
to
cf46306
Compare
pjedrzejewski
changed the title
[WIP][Shop] Integrate latest templates
[Shop] Integrate latest templates
Jun 12, 2016
@@ -58,8 +58,14 @@ security: | |||
check_path: sylius_shop_login_check | |||
failure_path: sylius_shop_login | |||
default_target_path: sylius_shop_homepage | |||
use_forward: false | |||
use_forward: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be reverted.
pjedrzejewski
force-pushed
the
ui/shop-integration
branch
from
June 13, 2016 20:26
4b12627
to
e69a605
Compare
pjedrzejewski
force-pushed
the
ui/shop-integration
branch
2 times, most recently
from
June 14, 2016 08:33
f807680
to
f31ea3c
Compare
pjedrzejewski
force-pushed
the
ui/shop-integration
branch
from
June 14, 2016 09:00
f31ea3c
to
d88ddb0
Compare
Great work Paweł! 👍 |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[Shop] Integrate latest templates
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[Shop] Integrate latest templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.